Add parameter to set a header containing the client ip #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtekel
reviewed
Feb 4, 2025
| <%- end -%> | ||
| <%- end -%> | ||
| <%- if_p("ha_proxy.true_client_ip_header") do |header| -%> | ||
| http-request set-header <%= header %> %[src] |
Contributor
There was a problem hiding this comment.
maybe remove two spaces in front of http-request so that this aligns with the rest of options when rendered?
hoffmaen
force-pushed
the
feat/true_client_ip_hdr
branch
from
6eb0438 to
0cbc7fe
Compare
maxmoehl
reviewed
Feb 10, 2025
hoffmaen
force-pushed
the
feat/true_client_ip_hdr
branch
from
649344e to
40176d6
Compare
maxmoehl
approved these changes
Feb 10, 2025
peanball
pushed a commit
that referenced
this pull request
Apr 8, 2025
This completes the True-Client-Ip feature introduced with #759. Three options are added to deal with the header: 1. forward_only_if_route_service: Forward only in route service scenario. This is the default behavior which adds support for the True-Client-Ip header in the route service scenario. 2. always_set: Always set the header, overwrite if existing. 3. always_forward: Always forward if existing, set otherwise. Co-authored-by: Clemens Hoffmann <clemens.hoffmann@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add property
ha_proxy.true_client_ip_header. This property allows to define a header name that stores the client src IP address, as seen by HAProxy.