Retain True-Client-Ip for Route Services #778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename acl true_client_ip_request to true_client_ip_found
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
peanball
added
run-ci
mtekel
approved these changes
Mar 28, 2025
mtekel
approved these changes
Mar 28, 2025
maxmoehl
reviewed
Apr 1, 2025
acceptance-tests/headers_test.go
Outdated
| Expect(recordedHeaders).To(HaveKey(headerKey)) | ||
| Expect(recordedHeaders[headerKey]).To(HaveLen(1)) | ||
| Expect(recordedHeaders[headerKey][0]).To(Equal("8.8.8.8")) | ||
| }) |
Member
There was a problem hiding this comment.
Please add tests for the other two cases as well.
Contributor
There was a problem hiding this comment.
Please add tests for the other two cases as well.
Done
maxmoehl
approved these changes
Apr 7, 2025
Member
maxmoehl
left a comment
maxmoehl
left a comment
There was a problem hiding this comment.
Once merged, please cut a major release right away to make sure we don't accidentally release this with a minor / patch.
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull-Request completes the True-Client-Ip feature introduced with #759. With this change, we add three options to deal with the header:
forward_only_if_route_service: Forward only in route service scenario. This is the default behavior which adds support for the True-Client-Ip header in the route service scenario.always_set: Always set the header, overwrite if existing.always_forward: Always forward if existing, set otherwise.