Skip to content

feat: add pollForProcessingImage #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
colbyfayock merged 2 commits into from
Aug 28, 2024
Merged

feat: add pollForProcessingImage #187

colbyfayock merged 2 commits into from
Aug 28, 2024

Conversation

@ghostdevv
Copy link
Contributor

@ghostdevv ghostdevv commented Aug 28, 2024

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@colbyfayock
Copy link
Collaborator

colbyfayock commented Aug 28, 2024

looks good, thanks @ghostdevv

@colbyfayock colbyfayock merged commit 8b7a1c7 into cloudinary-community:main Aug 28, 2024
github-actions bot pushed a commit that referenced this pull request Aug 28, 2024
@semantic-release-bot
chore(release): 3.3.0 [skip ci]
5b00379 
# [@cloudinary-util/util-v3.3.0](https://github.com/cloudinary-community/cloudinary-util/compare/@cloudinary-util/util-v3.2.0...@cloudinary-util/util-v3.3.0) (2024-08-28)

### Features

* add pollForProcessingImage ([#187](#187)) ([8b7a1c7](8b7a1c7))
@ghostdevv ghostdevv deleted the poll-image branch August 28, 2024 01:20
@ghostdevv ghostdevv mentioned this pull request Aug 28, 2024
Closed
This was referenced Aug 28, 2024
Closed
Merged
colbyfayock added a commit to cloudinary-community/next-cloudinary that referenced this pull request Aug 28, 2024
@colbyfayock
fix: Cleanup - pollForProcessingImage, preserveTransformations (#504)
c71ca67 
# Description

Uses newly exposed logic from URL Loader and Util to clean up duplicate
code for preserveTransformations and pollForProcessingImage

cloudinary-community/cloudinary-util#184
cloudinary-community/cloudinary-util#187
This was referenced Sep 4, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ghostdevv @colbyfayock