-
Notifications
You must be signed in to change notification settings - Fork 141
feat: added unique id generation using React's useId() hook
#529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added unique id generation using React's useId() hook
#529
Conversation
|
@sahil9001 is attempting to deploy a commit to the Cloudinary DevX Team on Vercel. A member of the Team first needs to authorize it. |
|
Relates to #493 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@sahil9001 this seems to work pretty well 1 thing i noticed is if you go to the Examples page and remove all of the IDs, which with this working properly should work, but it ends up breaking player configurations i tested locally replacing the |
|
Thanks @colbyfayock , I have added that now, please have a look. |
|
seems to work perfectly! thanks @sahil9001 This PR qualifies for free Hacktoberfest swag from Cloudinary. Please email me at hacktoberfest@cloudinary.com with your name, GitHub username, and a link to this PR |
|
@all-contributors please add @sahil9001 for code |
|
I've put up a pull request to add @sahil9001! 🎉 |
|
🎉 This PR is included in version 6.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Adds @sahil9001 as a contributor for code. This was requested by colbyfayock [in this comment](#529 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
# [7.0.0-beta.3](v7.0.0-beta.2...v7.0.0-beta.3) (2024-10-14) ### Bug Fixes * removed ts-ignore ([#535](#535)) ([32931c9](32931c9)), closes [#426](#426) * use more proper type to derive `CldVideoPlayerProps` ([#537](#537)) ([65c3dd1](65c3dd1)) ### Features * added unique id generation using React's `useId()` hook ([#529](#529)) ([682f4c2](682f4c2)), closes [#493](#493)
|
🎉 This PR is included in version 7.0.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Updates the Video Player to use the
useIdhook to reliably generate a unique player ID.Issue Ticket Number
Fixes #493
Type of change
Checklist