Skip to content

feat: added unique id generation using React's useId() hook #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colbyfayock merged 2 commits into from
Oct 3, 2024
Merged

feat: added unique id generation using React's useId() hook #529

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49a2fe0
feat: added unique id generation using React's `useId()` hook
sahil9001 Oct 3, 2024
31d4340
chore: fixed validation
sahil9001 Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions next-cloudinary/src/components/CldVideoPlayer/CldVideoPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, {useRef, MutableRefObject, useEffect} from 'react';
import React, {useRef, MutableRefObject, useEffect, useId} from 'react';
import Script from 'next/script';
import Head from 'next/head';
import { CloudinaryVideoPlayer } from '@cloudinary-util/types';
Expand Down Expand Up @@ -28,11 +28,11 @@ const CldVideoPlayer = (props: CldVideoPlayerProps) => {
width,
} = props as CldVideoPlayerProps;

const uniqueId = useId();

const cloudinaryConfig = getCloudinaryConfig(config);
const playerOptions = getVideoPlayerOptions(props, cloudinaryConfig);
const { publicId } = playerOptions;

if ( typeof publicId === 'undefined' ) {
throw new Error('Video Player requires a Public ID or Cloudinary URL - please specify a src prop');
}
Expand All @@ -46,7 +46,7 @@ const CldVideoPlayer = (props: CldVideoPlayerProps) => {
const defaultPlayerRef = useRef()as MutableRefObject<CloudinaryVideoPlayer | null>;
const playerRef = props.playerRef || defaultPlayerRef;

const playerId = id || `player-${publicId.replace('/', '-')}`;
const playerId = id || `player-${uniqueId.replace(/:/g, '')}`;
let playerClassName = 'cld-video-player cld-fluid';

if ( className ) {
Expand Down Expand Up @@ -137,7 +137,7 @@ const CldVideoPlayer = (props: CldVideoPlayerProps) => {
height={height}
/>
<Script
id={`cloudinary-videoplayer-${playerId}-${Math.floor(Math.random() * 100)}`}
id={`cloudinary-videoplayer-${playerId}`}
src={`https://unpkg.com/cloudinary-video-player@${PLAYER_VERSION}/dist/cld-video-player.min.js`}
onLoad={handleOnLoad}
onError={(e) => console.error(`Failed to load Cloudinary Video Player: ${e.message}`)}
Expand Down