Skip to content

Conversation

@MBcode
Copy link
Contributor

@MBcode MBcode commented Jul 19, 2022

Description

Review Time Estimate

  • Immediately
  • [x ] Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • [x ] I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This is for #295
Where I differentiate the Logger.error being for a [Dataset] or [Folder] and add the list of missing IDs
Logger.error("notfound=" + notFound.toString)

I then wrote some throw away test code, to kick it off, and see the resulting logs,
which I captured in the issue comments

MBcode added 3 commits July 18, 2022 16:44
differentiate as Dataset error, and add notfound
differentiate error message for Folders, and add notfound
@MBcode
Copy link
Contributor Author

MBcode commented Aug 1, 2022

was held up w/a CI bug that didn't have credentials for a github action to upload something for the mongodb container, but should be ok now

@robkooper
Copy link
Member

I wonder if this is related to #373

Copy link
Member

@robkooper robkooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make sure to update the changelog

@robkooper robkooper changed the base branch from develop to release/1.21.0 August 24, 2022 03:32
@robkooper robkooper added this to the 1.21.0 milestone Aug 26, 2022
@robkooper robkooper merged commit f8940ee into clowder-framework:release/1.21.0 Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants