Skip to content

Fix to remove a dataset from a space #349 #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robkooper merged 4 commits into from
Aug 24, 2022
Merged

Fix to remove a dataset from a space #349 #373

robkooper merged 4 commits into from
Aug 24, 2022

Conversation

@ddey2
Copy link
Member

@ddey2 ddey2 commented Aug 15, 2022 •
edited
Loading

Signed-off-by: Dipannita Dey ddey2@illinois.edu

Description

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ddey2
Fix to remove a dataset from a space #349
e8939e0 
Signed-off-by: Dipannita Dey <ddey2@illinois.edu>
@ddey2 ddey2 self-assigned this Aug 15, 2022
robkooper
robkooper reviewed Aug 15, 2022
View reviewed changes
@robkooper
Copy link
Member

robkooper commented Aug 15, 2022

can you update the CHANGELOG, and add a line that due to this bug, counts might be off and users should run the fixcounts script

robkooper
robkooper requested changes Aug 15, 2022
View reviewed changes
Copy link
Member

@robkooper robkooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • changelog
  • info -> debug

@ddey2 ddey2 requested a review from robkooper August 15, 2022 21:41
@robkooper robkooper mentioned this pull request Aug 17, 2022
Merged
10 tasks
@ddey2
Copy link
Member Author

ddey2 commented Aug 17, 2022

  • changelog
  • info -> debug

Done

@robkooper robkooper changed the base branch from develop to release/1.21.0 August 24, 2022 03:28
@robkooper robkooper merged commit 4f9d4ca into release/1.21.0 Aug 24, 2022
@robkooper robkooper deleted the ddey2/fix_removeDatasets branch August 24, 2022 03:29
@robkooper robkooper added this to the 1.21.0 milestone Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robkooper robkooper robkooper approved these changes

@longshuicy longshuicy longshuicy approved these changes

@lmarini lmarini Awaiting requested review from lmarini

@max-zilla max-zilla Awaiting requested review from max-zilla

Assignees

@ddey2 ddey2

Labels

None yet

Projects

None yet

Milestone

1.21.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ddey2 @robkooper @longshuicy