Skip to content

Fix to remove a dataset from a space #349 #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robkooper merged 4 commits into from
Aug 24, 2022
Merged

Fix to remove a dataset from a space #349 #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e8939e0
Fix to remove a dataset from a space #349
ddey2 Aug 15, 2022
ca3a046
Update MongoDBSpaceService.scala
ddey2 Aug 15, 2022
422eab1
Added the fix to changelog
ddey2 Aug 15, 2022
4133150
Merge branch 'ddey2/fix_removeDatasets' of https://github.com/clowder…
ddey2 Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

## Unreleased

### Fixed
- Fix to remove dataset from a space [#349](https://github.com/clowder-framework/clowder/issues/349)
(The count might be off to existing spaces, please run fixCounts script)

### Added
- MRI previewer for NIFTY (.nii) files.

Expand Down
1 change: 0 additions & 1 deletion app/services/mongodb/MongoDBSpaceService.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,6 @@ class MongoDBSpaceService @Inject() (
datasets.get(dataset) match {
case Some(x) => {
val datasetBytes = datasets.getBytesForDataset(dataset)
datasets.addToSpace(dataset, space)
ProjectSpaceDAO.update(MongoDBObject("_id" -> new ObjectId(space.stringify)), $inc("spaceBytes" -> -1 * datasetBytes), upsert=false, multi=false, WriteConcern.Safe)
ProjectSpaceDAO.update(MongoDBObject("_id" -> new ObjectId(space.stringify)), $inc("fileCount" -> -1 * x.files.length), upsert=false, multi=false, WriteConcern.Safe)
ProjectSpaceDAO.update(MongoDBObject("_id" -> new ObjectId(space.stringify)), $inc("datasetCount" -> -1), upsert=false, multi=false, WriteConcern.Safe)
Expand Down