Skip to content

Update installing_clowder.rst #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lmarini merged 1 commit into from
Sep 23, 2022
Merged

Update installing_clowder.rst #383

lmarini merged 1 commit into from
Sep 23, 2022

Conversation

@meerkatt
Copy link
Contributor

@meerkatt meerkatt commented Sep 22, 2022 •
edited
Loading

I believe there was a formatting issue in this yaml code on lines 216 and 239

Description

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@meerkatt
Update installing_clowder.rst
f927e40 
I believe there was a formatting issue in this yaml code on lines 216 and 239
@CLAassistant
Copy link

CLAassistant commented Sep 22, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

KastanDay
KastanDay approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@KastanDay KastanDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and is a necessary fix.

@KastanDay
Copy link
Contributor

KastanDay commented Sep 23, 2022

@lmarini Can we merge this doc fix? Looks good.

@lmarini lmarini merged commit 5f26ef6 into clowder-framework:develop Sep 23, 2022
@KastanDay KastanDay mentioned this pull request Nov 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robkooper robkooper robkooper approved these changes

@KastanDay KastanDay KastanDay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@meerkatt @CLAassistant @KastanDay @robkooper @lmarini