Skip to content

cli: provide zsh autocompletion script gen command#24400

Merged
nvb merged 1 commit into
cockroachdb:masterfrom
nvb:nvanbenschoten/zshComplete
Apr 2, 2018
Merged

cli: provide zsh autocompletion script gen command#24400
nvb merged 1 commit into
cockroachdb:masterfrom
nvb:nvanbenschoten/zshComplete

Conversation

@nvb
Copy link
Copy Markdown
Contributor

@nvb nvb commented Apr 2, 2018

This change extends the cockroach gen autocomplete command to support
the generation of zsh completion files. This has been supported
by spf13/cobra since spf13/cobra#497.

First two commits from #24399. Please ignore.

Release note (cli change): The "gen autocomplete" command can now
generator zsh-compatible completion files by passing "zsh" as an
argument.

@nvb nvb requested a review from a team as a code owner April 2, 2018 06:08
@nvb nvb requested a review from a team April 2, 2018 06:08
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@nvb nvb force-pushed the nvanbenschoten/zshComplete branch from a78eb1e to 1aad3df Compare April 2, 2018 15:41
@knz
Copy link
Copy Markdown
Contributor

knz commented Apr 2, 2018

:lgtm:


Reviewed 2 of 2 files at r3.
Review status: 2 of 17 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@nvb
Copy link
Copy Markdown
Contributor Author

nvb commented Apr 2, 2018

TFTR!

@nvb nvb force-pushed the nvanbenschoten/zshComplete branch from 1aad3df to b678c17 Compare April 2, 2018 18:22
This change extends the `cockroach gen autocomplete` command to support
the generation of `zsh` completion files. This has been supported
by `spf13/cobra` since spf13/cobra#497.

Release note (cli change): The "gen autocomplete" command can now
generator zsh-compatible completion files by passing "zsh" as an
argument.
@nvb nvb force-pushed the nvanbenschoten/zshComplete branch from b678c17 to 6b09bce Compare April 2, 2018 19:35
@nvb
Copy link
Copy Markdown
Contributor Author

nvb commented Apr 2, 2018

bors r+

@nvb nvb merged commit 07a01a4 into cockroachdb:master Apr 2, 2018
@nvb nvb deleted the nvanbenschoten/zshComplete branch April 2, 2018 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants