sql: add query level execution stats to sampled query log#87527
sql: add query level execution stats to sampled query log#87527craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
maryliag
left a comment
maryliag
left a comment
There was a problem hiding this comment.
Reviewed 4 of 6 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @maryliag and @THardy98)
pkg/util/log/eventpb/telemetry.proto line 147 at r1 (raw file):
// The number of network bytes sent by nodes for this query. int64 network_bytes_sent = 39 [(gogoproto.jsontag) = ',omitempty'];
looks like there will be some merge conflicts with https://github.com/cockroachdb/cockroach/pull/87508/files
you and @xinhaoz should coordinate on merges (or one can already rebase on the other)
THardy98
force-pushed
the
add_exec_stats_to_sampled_query
branch
from
ad84bed to
88af984
Compare
maryliag
left a comment
maryliag
left a comment
There was a problem hiding this comment.
Reviewed 1 of 6 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:
maryliag
left a comment
maryliag
left a comment
There was a problem hiding this comment.
you're missing some generated code, you need to run dev gen to create the docs
Reviewable status:
Partially addresses: cockroachdb#84729 This change adds: - network bytes sent - maximum memory usage - maximum disk usage - KV bytes read - KV rows read - network messages fields to the `SampledQuery` telemetry log. Release justification: low risk, high benefit changes to existing functionality Release note (sql change): This change adds:: - network bytes sent - maximum memory usage - maximum disk usage - KV bytes read - KV rows read - network messages fields to the `SampledQuery` telemetry log.
THardy98
force-pushed
the
add_exec_stats_to_sampled_query
branch
from
88af984 to
c546e33
Compare
|
CI failed essential Bazel CI on flakey eslint.sh test. Going to bors. |
|
bors r+ |
|
Build succeeded: |
3 participants
Partially addresses: #84729
This change adds:
fields to the
SampledQuerytelemetry log.Release justification: low risk, high benefit changes to existing functionality
Release note (sql change): This change adds::
SampledQuerytelemetry log.