Skip to content

release-22.2: sql: add query level execution stats to sampled query log#87648

Merged
THardy98 merged 1 commit intorelease-22.2from
blathers/backport-release-22.2-87527
Sep 9, 2022
Merged

release-22.2: sql: add query level execution stats to sampled query log#87648
THardy98 merged 1 commit intorelease-22.2from
blathers/backport-release-22.2-87527

Conversation

@blathers-crl
Copy link

@blathers-crl blathers-crl bot commented Sep 8, 2022

Backport 1/1 commits from #87527 on behalf of @THardy98.

/cc @cockroachdb/release


Partially addresses: #84729

This change adds:

  • network bytes sent
  • maximum memory usage
  • maximum disk usage
  • KV bytes read
  • KV rows read
  • network messages

fields to the SampledQuery telemetry log.

Release justification: low risk, high benefit changes to existing functionality

Release note (sql change): The SampledQuery telemetry log now includes fields for network bytes sent, maximum memory usage, maximum disk usage, KV bytes read, KV rows read, and network messages.


Release justification:

Partially addresses: #84729

This change adds:
- network bytes sent
- maximum memory usage
- maximum disk usage
- KV bytes read
- KV rows read
- network messages

fields to the `SampledQuery` telemetry log.

Release justification: low risk, high benefit changes to existing
functionality

Release note (sql change): This change adds::
- network bytes sent
- maximum memory usage
- maximum disk usage
- KV bytes read
- KV rows read
- network messages fields to the `SampledQuery` telemetry log.
@blathers-crl blathers-crl bot requested a review from a team September 8, 2022 20:46
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-87527 branch from d836c19 to 1aadef5 Compare September 8, 2022 20:46
@blathers-crl blathers-crl bot requested a review from maryliag September 8, 2022 20:46
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 8, 2022
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 8, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @THardy98)

@THardy98 THardy98 merged commit 8b87467 into release-22.2 Sep 9, 2022
@THardy98 THardy98 deleted the blathers/backport-release-22.2-87527 branch September 9, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants