release-22.2: sql: add query level execution stats to sampled query log#87648
Merged
THardy98 merged 1 commit intorelease-22.2from Sep 9, 2022
Merged
release-22.2: sql: add query level execution stats to sampled query log#87648THardy98 merged 1 commit intorelease-22.2from
THardy98 merged 1 commit intorelease-22.2from
Conversation
Partially addresses: #84729 This change adds: - network bytes sent - maximum memory usage - maximum disk usage - KV bytes read - KV rows read - network messages fields to the `SampledQuery` telemetry log. Release justification: low risk, high benefit changes to existing functionality Release note (sql change): This change adds:: - network bytes sent - maximum memory usage - maximum disk usage - KV bytes read - KV rows read - network messages fields to the `SampledQuery` telemetry log.
d836c19 to
1aadef5
Compare
Author
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
Member
maryliag
approved these changes
Sep 9, 2022
Contributor
maryliag
left a comment
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @THardy98)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #87527 on behalf of @THardy98.
/cc @cockroachdb/release
Partially addresses: #84729
This change adds:
fields to the
SampledQuerytelemetry log.Release justification: low risk, high benefit changes to existing functionality
Release note (sql change): The
SampledQuerytelemetry log now includes fields for network bytes sent, maximum memory usage, maximum disk usage, KV bytes read, KV rows read, and network messages.Release justification: