Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented May 5, 2025

@Didayolo

Description

Submission files were copied to prediction dir that was problematic for storage. This was only happening when submission had no metadata file.

NOW, in any case submission files are not copied to predictions dir. The code is also a bit simplified for clarity

Issues this PR resolves

A checklist for hand testing

  • upload a big submission and check that in the predictions result submission files are not copied
  • Also check that when submission is processed the quota remains the same (not doubling in size)

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

Didayolo commented May 5, 2025

Note: the deployment requires:

  • Updating the compute worker docker image
  • Updating all workers

@Didayolo Didayolo linked an issue May 5, 2025 that may be closed by this pull request
@Didayolo Didayolo self-assigned this May 6, 2025
@Didayolo
Copy link
Member

Didayolo commented May 15, 2025

Pushed this in codalab/competitions-v2-compute-worker:test (by modifying compute_worker.py inside the container and using a docker push)

By the way, it can be the occasion to update the compute worker image, which still runs under Python3.9


Not sure if it's the way I updated it or an actual bug from the code, but I can't start the compute worker

@ihsaan-ullah
Copy link
Collaborator Author

@Didayolo on my side I am able to build and run the compute worker image.

Steps:

  1. Build
docker build -f Dockerfile.compute_worker -t compute-worker-image .
  1. Run with bash
docker run -it --entrypoint /bin/bash compute-worker-image
  1. Check the latest code
cat compute_worker.py

@Didayolo
Copy link
Member

Didayolo commented Jun 5, 2025

@ihsaan-ullah Indeed, the build works. I don't know what was my problem previously, but maybe it was something with my local configuration. I'll pursue de testing then.

@Didayolo Didayolo merged commit 16d73c3 into develop Jun 5, 2025
1 check passed
@Didayolo Didayolo deleted the submission_duplicate_in_prediction_output branch June 5, 2025 11:07
@Didayolo
Copy link
Member

Didayolo commented Jun 5, 2025

Built and pushed to:

  • codalab/competitions-v2-compute-worker:cpu1.2
  • codalab/competitions-v2-compute-worker:gpu1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discrepancy in Reported Storage Quota Usage

3 participants