Skip to content

Conversation

@Didayolo
Copy link
Member

@Didayolo Didayolo commented Jul 11, 2025

Mention of reviewer

@ihsaan-ullah

Description

Put back copy of submission files into prediction output in compute worker

It was remove to try to solve #1833 (PR #1841) but broke results submissions.

This PR revert back this change. We need in the future to move the duplication in scoring program instead of ingestion program to avoid using storage wrongly.

A checklist for hand testing

  • Test code submissions
  • Test results submissions
  • Check that submissions files are visible inside the "output from prediction step"

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah
Copy link
Collaborator

Tested locally. Works perfectly. Ready to be merged

@Didayolo Didayolo merged commit dc19e4a into develop Jul 14, 2025
1 check passed
@Didayolo Didayolo deleted the revert-copy-compute-worker branch July 14, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants