Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Jun 25, 2025

Description

This PR has the following changes:

  • add filters to the public competition page (search title --- order based on recent, popular, submissions --- show comps you are organizing or participating in)
  • activate the concerned filters when you click Show more button for Recent or Popular benchmarks on the home page
  • tests added for public competitions

Screenshots

Filter page
Screenshot 2025-06-25 at 5 48 00 PM

Error when user is not loggedin and tries to use participaitng in and organizing filters
Screenshot 2025-06-25 at 5 48 07 PM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

Didayolo commented Jun 25, 2025

Great job @ihsaan-ullah, thank you very much! Some remarks.

Has reward filter

One more filter that is relevant, that I forgot to add when I updated the issue earlier, is "has reward". When you select it, only competitions with non-empty reward field would appear. What do you think? It was done on the draft PR #1825.

UI when no results

When there is no results to the filter:

  • The pagination is "1 of 0"
  • We could add a message like "No matching results."
Capture d’écran 2025-06-25 à 15 36 43

Styling

Another remark, that is a detail, but the styling of the search bar and of the button "Clear All Filters" is not beautiful, not fitting the style of other buttons of the site.

It works fine

Outside of this UI remarks, the feature is working fine in terms of functionality. I'll continue the testing.

@Didayolo Didayolo self-assigned this Jun 25, 2025
@ihsaan-ullah
Copy link
Collaborator Author

Updates

  1. Style fixed
  2. Reward added to filters
  3. Tests updated
  4. Empty response handled

Screenshots

Screenshot 2025-06-26 at 3 08 08 PM Screenshot 2025-06-26 at 3 08 16 PM

@ihsaan-ullah
Copy link
Collaborator Author

Please don't forget to test if the filters work properly when you click view more button for recent/popular benchmarks on home page

@Didayolo
Copy link
Member

This is great work, and you included deep testing

@Didayolo Didayolo merged commit 587442f into develop Jun 26, 2025
1 check passed
@Didayolo Didayolo deleted the competition_filters branch June 26, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants