Skip to content

Conversation

@bbearce
Copy link
Collaborator

@bbearce bbearce commented Aug 17, 2022

@ mention of reviewers

@Didayolo, @Tthomas63

A brief description of the purpose of the changes contained in this PR.

This PR is for getting the leaderboard to show results from submissions

Issues this PR resolves

When loading the main page for a competition, codabench also loads the leaderboard. There were two issues:

  • compute_worker.py: The yaml loader that parses the leaderboard scores needed a "yaml.Loader" argument as well as the file object.
  • leaderboards.py: had a column serializer that was only returning leaderboards for competitions with more than one metric. I changed so that it accepts 1 or more metrics.

A checklist for hand testing

  • upload comp
  • make submission
  • add results to leaderboard
  • check leaderboard for results

Any relevant files for testing

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • Ready to merge

@Didayolo Didayolo self-requested a review August 23, 2022 15:46
@Didayolo Didayolo merged commit c5df1e1 into develop Aug 24, 2022
@Didayolo Didayolo deleted the leaderboard_v2_comp_fixes branch August 24, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants