Skip to content

Leaderboard v2 comp fixes #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Didayolo merged 2 commits into from
Aug 24, 2022
Merged

Leaderboard v2 comp fixes #704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c2811e
edit compute worker so that yaml gets correct amount of inputs
Aug 1, 2022
9b535eb
allow leaderboard to show comp results for more than 1 column
Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/compute_worker/compute_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,7 @@ def push_scores(self):
elif os.path.exists(os.path.join(self.output_dir, "scores.txt")):
scores_file = os.path.join(self.output_dir, "scores.txt")
with open(scores_file) as f:
scores = yaml.load(f)
scores = yaml.load(f, yaml.Loader)
else:
raise SubmissionException("Could not find scores file, did the scoring program output it?")

Expand Down
2 changes: 1 addition & 1 deletion src/apps/api/serializers/leaderboards.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def get_columns(self, instance):
if len(columns) == 0:
raise serializers.ValidationError("No columns exist on the leaderboard")
else:
return ColumnSerializer(columns, many=len(columns) > 1).data
return ColumnSerializer(columns, many=len(columns) >= 1).data

class Meta:
model = Phase
Expand Down