Skip to content

Conversation

@bbearce
Copy link
Collaborator

@bbearce bbearce commented Mar 20, 2023

Template

Last couple of email changes to not delete users if activation is wrong and remove chahub buttons

@ mention of reviewers

@Didayolo
@madclam

A brief description of the purpose of the changes contained in this PR.

If the user clicks the activation link or copies I incorrectly somehow and it is not correct codabench was deleting the user account. Instead we no longer do that. This way worst case an admin can just find the account in question and activate it from the backend database.

Issues this PR resolves

...

Known issues to be addressed in a separate PR

...

A checklist for hand testing

  • create account and click activation email
  • login afterwards

Any relevant files for testing

link to any relevant files (or drag and drop into github)

Misc. comments

...

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • Ready to merge

@Didayolo Didayolo merged commit d365e68 into master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants