Participant can access private competition without secret key #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
|
@ihsaan-ullah Thank you for your contributions as always! I've reviewed it and it work as excepted. Once accepted (auto or manual) in a competition, the public link works. Even if denied from the competition after being accepted, the public link still work. For me it is the normal behavior, as in any case you need to have the secret URL at some point to be able to see a private competition (or be an admin of it). The code change is simple and works well with the rest of the code. I merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ mention of reviewers
@Didayolo @bbearce
A brief description of the purpose of the changes contained in this PR.
A participant of a competition was not able to access the competition without secret key in the URL.
Now the same participant will be able to access a private competition
Issues this PR resolves
#832
Checklist