Skip to content

Participant can access private competition without secret key #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Didayolo merged 1 commit into from
May 4, 2023
Merged

Participant can access private competition without secret key #839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/apps/competitions/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from django.http import Http404
from django.views.generic import TemplateView, DetailView

from .models import Competition
from .models import Competition, CompetitionParticipant


class CompetitionManagement(LoginRequiredMixin, TemplateView):
Expand All @@ -29,8 +29,12 @@ def get_object(self, *args, **kwargs):
competition = super().get_object(*args, **kwargs)
is_creator = self.request.user.is_superuser or self.request.user == competition.created_by
is_collaborator = self.request.user in competition.collaborators.all()

# get participants from CompetitionParticipant where user=user and competition=competition
is_participant = CompetitionParticipant.objects.filter(user=self.request.user, competition=competition).count() > 0

valid_secret_key = self.request.GET.get('secret_key') == str(competition.secret_key)
if is_creator or is_collaborator or competition.published or valid_secret_key:
if is_creator or is_collaborator or competition.published or valid_secret_key or is_participant:
return competition
raise Http404()

Expand Down