do not show empty leaderboard table when user is not loggedin #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@ihsaan-ullah Nice way to handle this problem! I'll review it soon. |
Member
|
It works well. Just, I am not sure if this is due to your code of if this behavior is buggy in general, but the login with the |
Collaborator
Author
|
This is normal behaviour. |
Member
|
OK so I'll create an issue about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ mention of reviewers
@Didayolo
A brief description of the purpose of the changes contained in this PR.
Now users will not see empty leaderboard table when not loggedin.
A warning message is shown to login with links to login or sign up
Issues this PR resolves
#749
Checklist