Skip to content

do not show empty leaderboard table when user is not loggedin #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Didayolo merged 1 commit into from
May 22, 2023
Merged

do not show empty leaderboard table when user is not loggedin #883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/static/riot/competitions/detail/_tabs.tag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,15 @@
<loader></loader>
</div>
<!-- Tab Content !-->
<div show="{!loading}">
<div class="row" if="{!CODALAB.state.user.logged_in}">
<div class="column">
<div class="ui yellow message">
<a href="{URLS.LOGIN}?next={location.pathname}">Log In</a> or
<a href="{URLS.SIGNUP}" target="_blank">Sign Up</a> to view this competition results.
</div>
</div>
</div>
<div if="{CODALAB.state.user.logged_in}" show="{!loading}">
<div class="ui button-container inline">
<div class="ui button {active: selected_phase_index == phase.id}"
each="{ phase in competition.phases }"
Expand All @@ -244,6 +252,7 @@
<div show="{!loading && _.isEmpty(competition.leaderboards)}">
<div class="center aligned"><h2>No Visible Leaderboards for this competition</h2></div>
</div>

</div>
</div>

Expand Down