Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented May 29, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Now users will be redirected to the competition page after login if login is initiated from competition pages either from submissions tab or leaderboard tab
Screenshot 2023-05-29 at 2 56 38 PM
Screenshot 2023-05-29 at 2 56 48 PM

When users click login in these pages, they will be redirected to login page, after login they will be redirected to the same competition page and not to home page

Issues this PR resolves

#886

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

Perfect :-)

@Didayolo Didayolo merged commit 69bf79b into develop May 30, 2023
@Didayolo Didayolo deleted the redirect_after_login branch May 30, 2023 11:15
Didayolo added a commit that referenced this pull request Jun 1, 2023
* html comment fixed

* repeated competitions in competitions api fixed

* uploading a submission, show asterick with required only answers

* do not show make private/public button to users who are not owner of the submission

* Remove console calls

* Resources -> Datasets : fiel sizes added in readable format

* console log removed

* Update management.tag

* pagination fixed

* Show competition name in Resources -> Datasets

* filename added in request, test updated

* Dataset detail tile changed to file name

* Use title and url of benchmark in job status page

* competition name is now a clickable link

* competition name clickable in dataset detail

* Update management.tag

* Update management.tag

* separate tab for submissions

* Add Dataset changed to Add Dataset/Program

* Add submission modal added

* After login redirect to `next` page (#900)

* after login redirect to next page

* trailing white space removed

---------

Co-authored-by: Ihsan Ullah <ihsanullah@Pixel-io.local>

* benchmark title instead of id in datasets detail

* Tasks tab: benchmark is now clickable link

* milliseconds -> seconds

* add option to show/hide public submissions/datasets

* new filters added to show/hide public submissions and datasets/programs

* default filter added

* unused function removed

* delete button is now shown for own submissions and datasets/programs only

* Save leaderboard during manual creation of benchmark (#908)

* Save leaderboard during manual creation of benchmark

* Update competitions.py

* Fix the test: precision should be a number

---------

Co-authored-by: Ihsan Ullah <ihsanullah@Pixel-io.local>
Co-authored-by: Ihsan Ullah <ihsan2131@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants