Save leaderboard during manual creation of benchmark #908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Didayolo
added a commit
that referenced
this pull request
Jun 1, 2023
* html comment fixed * repeated competitions in competitions api fixed * uploading a submission, show asterick with required only answers * do not show make private/public button to users who are not owner of the submission * Remove console calls * Resources -> Datasets : fiel sizes added in readable format * console log removed * Update management.tag * pagination fixed * Show competition name in Resources -> Datasets * filename added in request, test updated * Dataset detail tile changed to file name * Use title and url of benchmark in job status page * competition name is now a clickable link * competition name clickable in dataset detail * Update management.tag * Update management.tag * separate tab for submissions * Add Dataset changed to Add Dataset/Program * Add submission modal added * After login redirect to `next` page (#900) * after login redirect to next page * trailing white space removed --------- Co-authored-by: Ihsan Ullah <ihsanullah@Pixel-io.local> * benchmark title instead of id in datasets detail * Tasks tab: benchmark is now clickable link * milliseconds -> seconds * add option to show/hide public submissions/datasets * new filters added to show/hide public submissions and datasets/programs * default filter added * unused function removed * delete button is now shown for own submissions and datasets/programs only * Save leaderboard during manual creation of benchmark (#908) * Save leaderboard during manual creation of benchmark * Update competitions.py * Fix the test: precision should be a number --------- Co-authored-by: Ihsan Ullah <ihsanullah@Pixel-io.local> Co-authored-by: Ihsan Ullah <ihsan2131@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A brief description of the purpose of the changes contained in this PR.
Upon manual UI challenge creation, the leaderboard isn't saved.
Issues this PR resolves
A checklist for hand testing
Any relevant files for testing
N/A
Misc. comments
I'm worried that this fix and the underlying code I copied or updating a challenge is not what the original creators wanted. See this comment above the code I copied:
codabench/src/apps/api/views/competitions.py
Line 148 in 73cacee
Checklist