-
Notifications
You must be signed in to change notification settings - Fork 45
leaked users fixed #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
leaked users fixed #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
Collaborator
Author
Contributor
|
I think we should remove also "id" and "status" of users. Exposing the least information to public is the general security rule. |
Collaborator
Author
Member
|
I rebased the branch to have the CircleCI test fix. |
Closed
Collaborator
Author
Contributor
|
Tested, it's good to be merged ! |
This was referenced Jun 30, 2023
Closed
Member
You were right! |
Didayolo
added a commit
that referenced
this pull request
Jun 30, 2023
Revert "leaked users fixed (#929)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.






@ mention of reviewers
@Didayolo
A brief description of the purpose of the changes contained in this PR.
Now user email will not be leaked in these apis:
now only username is shown in collaborators
Now email is removed from the participants
Issues this PR resolves
#885
Checklist