Skip to content

Merge develop into master #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Didayolo merged 15 commits into from
Jun 23, 2023
Merged

Merge develop into master #956

Didayolo merged 15 commits into from
Jun 23, 2023

Conversation

@Didayolo
Copy link
Member

@Didayolo Didayolo commented Jun 16, 2023 •
edited
Loading

TO BE TESTED

Deployed on https://codabench-test.lri.fr/

Cleanup and quota

At the bottom of the resources interface:

  • Delete unused tasks
  • Delete unused datasets
  • Delete unused submissinos
  • Delete failed submissions

Phase status fixed

Dynamic news edition

https://github.com/codalab/codabench/wiki/Administrator-procedures

Number of entries in leaderboard fixed

Leaked users fixed

Organization

Add phase fixed

Update text in front page

The paragraphs "What is CodaLab", "What is Codabench", "History of CodaLab", etc. was updated.

  • Proof-read the paragraphs
  • Test the links

ihsaan-ullah and others added 4 commits June 13, 2023 01:18
@ihsaan-ullah
phase status fixed. now used in api and views
bee93d2
@ihsaan-ullah @Didayolo
Resource interface : Cleanup and Quota (#918)
17c9c09 
* resource interface show orphans and delete option

* Flake errors fixed

* cleanup delete apis implemented

* flake error

* resource interface show orphans and delete option

* Flake errors fixed

* cleanup delete apis implemented

* flake error

* unused tasks and unused datasets fixed

* flake

* comments fixed

---------

Co-authored-by: didayolo <adrien.pavao@gmail.com>
@Didayolo
Merge pull request #934 from codalab/phase_status_null
283360d 
Phase status fixed
@Didayolo
CodaBench --> Codabench in README.md
00f638d
@ihsaan-ullah
Copy link
Collaborator

ihsaan-ullah commented Jun 17, 2023 •
edited
Loading

Test Report

Cleanup and quota (#918)

Correct cleanup statistic

  • number of unused submissions
  • number of unused tasks
  • number of unused datasets
  • number of failed submissions

Delete

  • Delete unused tasks
    ❗Problem: the datasets used in the deleted task (if not used in any other tasks) are not shown in the cleanup statistics
    ✅ Solution: refresh unused tasks, unused datasets and clearnup statistics after task deletion
    Solved by: Resource cleanup tests #958
  • Delete unused datasets
  • Delete unused submissinos
  • Delete failed submissions
    ❗ Problem: Submission is deleted from competition but it stays in the resource->submissions tab
    ✅ Solution: ❌

Some more problems identified while testing the above change

  1. Deleting a compeition does not delete its tasks
  2. Deleting a task does not delete its datasets (this seems to be a problem when the task is autocreated)
  3. Deleting auto created task results in unused datasets (auto created datasets). Count is shown in cleanup statistics but these are not shown in datasets tab unless auto created is checked

Phase status fixed (#934)

The following work for both admin and participant of a competition

  • Make a submission in a never ending phase
  • Cannot make submission in ended pahse
  • Cannot make submission in not started pahse
  • show warning message for both not started and ended phases

Number of entries in leaderboard fixed (#966 )

  • Leaderboard shows correct number of entries

ihsaan-ullah and others added 3 commits June 19, 2023 16:36
@ihsaan-ullah
Resource cleanup tests (#958)
c39a631 
* cleanup stats

* tasks fixed

* url name added

* count fixed

* failed submission fixed

* check response

* setup fixed

* submission factory updated

* data in submission

* delete tests added

* delete method fixed

* reload unused datasets on unused tasks deletion

* exception wrapped to avoid json serilizer error

* on deletion of tasks, reload cleanup statistics
@ihsaan-ullah
Dynamic announcement and news added (#952)
bcbbf79 
* Dynamic announcement and news added

* unused test file removed

* News section comment added

* unused view file removed

* news title unique removed

* news ordered by id DESC

* news link made optional
@ihsaan-ullah @Didayolo
number of entries in leaderboard fixed (#966)
014beb1 
* number of entries fixed

* Remove print

---------

Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>
@dtuantran
Copy link
Contributor

dtuantran commented Jun 20, 2023

After deleting unused task, I got the button "Delete unused dataset/program" but there is no dataset/program appeared on my account.
image

@ihsaan-ullah
Copy link
Collaborator

ihsaan-ullah commented Jun 20, 2023

After deleting unused task, I got the button "Delete unused dataset/program" but there is no dataset/program appeared on my account.

This is because these datasets are auto created and if you check the auto created checkbox, you can see them

@Didayolo
Copy link
Member Author

Didayolo commented Jun 20, 2023

Add documentation (in "administrator procedures"?) about this feature, with screenshots

We need to remember to add documentation about the dynamic news edition. It should be stated that it is HTML, so links can be added, etc.

@dtuantran
Copy link
Contributor

dtuantran commented Jun 21, 2023

After deleting unused task, I got the button "Delete unused dataset/program" but there is no dataset/program appeared on my account.

This is because these datasets are auto created and if you check the auto created checkbox, you can see them

I clicked "autocreated" but there is nothing from my account

ihsaan-ullah and others added 8 commits June 21, 2023 16:06
@ihsaan-ullah @Didayolo
leaked users fixed (#929)
e9f7ef4 
* leaked users fixed

* separate serializer added for participants with email

* participants id and status hidden

* Update models.py

---------

Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>
@ihsaan-ullah
commented code removed
ee50667
@Didayolo
Merge pull request #978 from codalab/remove_home_commented_code
bceb5ea 
commented code removed
@ihsaan-ullah @Didayolo
Submit as organization made clear (#976)
2ccacd3 
* organization message displayed

* spelling mistake fixed

* add organization added in dropdown

* Correct typo

---------

Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>
@ihsaan-ullah
Organization delete functionality added (#959)
5205b0a 
* Organization delete functionality added

* Codalab->Codabench

* delte restricted to owner only
@ihsaan-ullah
adding new phase in competition fixed (#963)
7b72adf 
* adding new phase in competition fixed

* unused import removed

* auto_migrate_removed from new created phase

* transaction added

* no end date handled
@Didayolo
Update text in home.html
469cdd9
@Didayolo
Merge pull request #983 from codalab/frontpage
1524632 
Update text in home.html
@Didayolo Didayolo merged commit 97ecdb0 into master Jun 23, 2023
@Didayolo
Copy link
Member Author

Didayolo commented Jun 23, 2023

It's merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Didayolo @ihsaan-ullah @dtuantran