Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Jun 22, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Now users can see a message and link to create organization when no organization has been created

No organization
Screenshot 2023-06-22 at 1 48 06 PM

Has organization
Screenshot 2023-06-22 at 1 47 38 PM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

Didayolo commented Jun 22, 2023

In my opinion it would be better if create organization is shown only when you click on the bar, like this:

Capture d’écran 2023-06-22 à 13 20 21 Capture d’écran 2023-06-22 à 13 20 28

It is sufficient to make it clear and it avoids cluttering the interface.

Sorry if it was clear in comment in the issue. Would that be easy to implement?

@ihsaan-ullah
Copy link
Collaborator Author

I am not sure if a dropdown can be used like this.

@Didayolo
Copy link
Member

OK.

Also, the link is not displayed if you have already created an organization (which is what we want indeed). But is it displayed when you are part of an organization you did not create? I guess you should be able to submit as an organization you are part of, and the link should not be shown then.

@ihsaan-ullah
Copy link
Collaborator Author

Trying to achieve this
Screenshot 2023-06-22 at 4 54 41 PM

@Didayolo
Copy link
Member

OK. If it is too complicated, don't spend too much time on this I guess :-)

@ihsaan-ullah
Copy link
Collaborator Author

Screenshot 2023-06-22 at 5 38 41 PM Screenshot 2023-06-22 at 5 38 55 PM

I confirm that in the dropdown we can only see organizations you have created. Other organizations where you are invited are not shown

@Didayolo
Copy link
Member

Very nice changes! The use of the question mark is clearly smoother.

I confirm that in the dropdown we can only see organizations you have created. Other organizations where you are invited are not shown

OK, I guess this is a separate issue. The organization system is not completely done apparently.

@ihsaan-ullah
Copy link
Collaborator Author

ihsaan-ullah commented Jun 22, 2023

If an organization is used in a submission, it cannot be deleted. Is this what we want?

If not then this filed should be updated:

organization = models.ForeignKey(Organization, related_name='submissions', on_delete=models.DO_NOTHING, null=True)

This and the above are two separate issues

@Didayolo
Copy link
Member

If an organization is used in a submission, it cannot be deleted. Is this what we want?

I think we always want to be able to delete submissions. However, I'm not sure how this should be managed. Indeed, it is also a separate issue. Maybe we need a general issue about organization to brainstorm a bit. We can use this one:

@Didayolo Didayolo merged commit 2ccacd3 into develop Jun 22, 2023
@Didayolo Didayolo deleted the submit_as_organization branch June 22, 2023 13:26
This was referenced Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants