Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Jun 15, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Now admins can add announcement and news posts from admin section (http://localhost/admin/)

Admin can see Announcement and News post here:
Screenshot 2023-06-16 at 12 40 29 AM

#Annoucnement

Annoucement if available is shown on the main page
Screenshot 2023-06-16 at 12 36 21 AM
Screenshot 2023-06-16 at 12 32 09 AM

Note: only the first announcement is fetched in the code. At a time only one announcement will be shown.
HTML is supported

News Posts

News post can be added in the news post section
Screenshot 2023-06-16 at 12 36 30 AM
Screenshot 2023-06-16 at 12 35 39 AM
Screenshot 2023-06-16 at 12 43 57 AM

Note: In news text html can be added e.g. a link or bold text

Issues this PR resolves

#787

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

That looks absolutely great! I'll review it after having review the other PRs.

@Didayolo
Copy link
Member

Didayolo commented Jun 16, 2023

@ihsaan-ullah This works well, congrats.

Some remarks:

  • Make the "link" field should not be required? Sometimes a news is not associated to a link:
Capture d’écran 2023-06-16 à 15 13 53
  • Should we have a default anouncement, e.g. an object with "Welcome to Codabench"? Should we have also default news with the list that was previously there? What do you think? I guess a default announcement is good, maybe for the news is not a good idea because it'll be outdated eventually.

@ihsaan-ullah
Copy link
Collaborator Author

@Didayolo

I will fix the link

Regarding the default announcement: we can have one announcement which contains some text. This one announcement should be updated or deleted to show/hide the required message. we can have only one announcement object only

I am not sure if i understood the default news.

@Didayolo
Copy link
Member

@ihsaan-ullah I don't think we need to change how it works right now.

It is good to have multiple announcement and only one taken into account, because then as an admin you can keep track of previous announcement.

The goal of having an announcement already there by default is to have something displayed when you setup the platforme for the first time.

@Didayolo Didayolo merged commit bcbbf79 into develop Jun 19, 2023
@Didayolo Didayolo deleted the announcements branch June 19, 2023 14:40
@Didayolo Didayolo mentioned this pull request Jun 19, 2023
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants