Skip to content

Detailed results displayed for each task on leaderboard #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Didayolo merged 3 commits into from
Jul 21, 2023
Merged

Detailed results displayed for each task on leaderboard #967

Didayolo merged 3 commits into from
Jul 21, 2023

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Jun 20, 2023 •
edited by Didayolo
Loading

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Now users can see detailed results for each task in leaderboard
Screenshot 2023-06-20 at 6 32 19 AM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah mentioned this pull request Jul 5, 2023
Closed
@Didayolo
Copy link
Member

Didayolo commented Jul 11, 2023

@ihsaan-ullah

It looks like Fact Sheet Answers is considered as a task and have it's own link for detailed results (which results, unsurprisingly, to a 404 error):

Capture d’écran 2023-07-11 à 17 33 11

This column should not be created.

@Didayolo Didayolo self-assigned this Jul 11, 2023
@ktgiahieu
Copy link

ktgiahieu commented Jul 21, 2023

@ihsaan-ullah @Didayolo

How can I help you test it and make the required modification? In principle, we are opening our competition on Monday, and it will be confusing to users if they don't get the proper feedback.

@ihsaan-ullah
Copy link
Collaborator Author

ihsaan-ullah commented Jul 21, 2023

@Didayolo with the latest push the problem should be fixed.

Here is a screenshot
Screenshot 2023-07-21 at 6 30 00 PM

@ihsaan-ullah
Copy link
Collaborator Author

ihsaan-ullah commented Jul 21, 2023

@ihsaan-ullah @Didayolo

How can I help you test it and make the required modification? In principle, we are opening our competition on Monday, and it will be confusing to users if they don't get the proper feedback.

@ktgiahieu If you want to test this locally, you can start with these instructions :
https://github.com/codalab/codabench/wiki/Codabench-Installation

switch to this branch before testing

@Didayolo Didayolo merged commit 5d96408 into develop Jul 21, 2023
@Didayolo Didayolo deleted the detailed_results branch July 21, 2023 16:31
@Didayolo
Copy link
Member

Didayolo commented Jul 21, 2023

@ktgiahieu The change is now merged on develop, but still not deployed on production.

We'll deploy it on the test server first, where you'll be able to test the feature and confirm it is working well before we merge into master (and the main server).

Right now we have a problem with the deployment on the test server, I'll let you know when it is ready.

@Didayolo Didayolo mentioned this pull request Jul 25, 2023
Merged
Didayolo added a commit that referenced this pull request Jul 25, 2023
@Didayolo @ihsaan-ullah @bbearce
Merge pull request #1028 from codalab/develop
663681c 
* do not show hidden column in leaderboard, unpacker v1 to handle hidden column

* LEADERBOARD_V1 data updated with hidden attribute

* filter: hidden condition removed

* analytics download fixed

* default profile avatar changed

* Detailed results displayed for each task on leaderboard (#967)

* Detailed results displayed for each task on leaderboard

* more explanation added to detailed result fetching. url commented

* detailed results removed from factsheets

* Download buttons (#970)

* download_buttons progress 06_03_2023

* List the Files on Files Tab

* download buttons update

* dataset download added to UI.

* 06_24_2023 progress

* unpackers, polishing and fixing test errors

* last bit of test fixes.

* flake issues

* pytest errors

* single select and final touches

* flake and fixing tests

* remove dev docker-compose file

* hide all but public_startingkit data for no admin

* Don't show non-registered\unlogged-in participants

* Improve display

---------

Co-authored-by: didayolo <adrien.pavao@gmail.com>

---------

Co-authored-by: Ihsan Ullah <ihsan2131@gmail.com>
Co-authored-by: Benjamin Bearce <bbearce@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Didayolo Didayolo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ihsaan-ullah @Didayolo @ktgiahieu