Download buttons #970

bbearce · 2023-06-21T07:30:44Z

@ mention of reviewers

@Didayolo
@ihsaan-ullah

A brief description of the purpose of the changes contained in this PR.

Adding the ability to add/edit public_data and starting_kit in phase.

Status:

Starting Kit and Public Data need to be phase level objects. - DONE
Need to see in Files list. - DONE
Need to add phase edit ability to see datasets as options to be selected and associated to phase. - DONE
Need to save to database on competition edit save. - DONE
Then need to adjust unpacker to allow them through via yaml for both v1 and v2. - DONE
[FOR NEXT PR] Need to be able to decide what datasets are public. - NOT DONE
DISCLAIMER NOT DONE --> separated PR

Issues this PR resolves

A checklist for hand testing

Make competition upload bundle

Upload a V1 bundle with starting kit and public data and check it's there
Upload a V2 bundle with starting kit and public data as ZIP files and check it's there
Upload a V2 bundle with starting kit and public data as folders and check it's there
Add Phase with public_data and starting_kit with at least one task with other 4 datasets (id, rf, ip, sp)
Add Phase with no public_data or starting_kit with at least one task with other 4 datasets (id, rf, ip, sp)
Add Phase with public_data only with at least one task with other 4 datasets (id, rf, ip, sp)
Add Phase with starting_kit only with at least one task with other 4 datasets (id, rf, ip, sp)
Try with more than one phase as well with at least one task with other 4 datasets (id, rf, ip, sp) with both tasks with other 4 datasets (id, rf, ip, sp)
Check competition has data you expect in Files list under Get Started and in Competition editor under phases

Make manual competition

* Add Phase with public_data and starting_kit with at least one task with other 4 datasets (id, rf, ip, sp)
* Add Phase with no public_data or starting_kit with at least one task with other 4 datasets (id, rf, ip, sp)
* Add Phase with public_data only with at least one task with other 4 datasets (id, rf, ip, sp)
* Add Phase with starting_kit only with at least one task with other 4 datasets (id, rf, ip, sp)
Try with more than one phase as well with at least one task with other 4 datasets (id, rf, ip, sp) with both tasks with other 4 datasets (id, rf, ip, sp)
Save and check competition has data you expect in Files list under Get Started and in Competition editor under phases

Edit pre-existing competition

* Edit Phase with public_data and starting_kit and change both to none
* Edit Phase with no public_data or starting_kit and change both to something
* Edit Phase with public_data only and make starting_kit only
* Edit Phase with starting_kit only and make public_data only
Try with more than one phase as well
Save and check competition has data you expect in Files list under Get Started and in Competition editor under phases

Double Check

In Competition go under Get Started \ Files and check that the files visible match the files in:
* All datasets attached to each task
* public_data and or starting_kit associated with each phase

Any relevant files for testing

...I can make a variation on classify wheat seeds for this testing

Checklist

bbearce · 2023-06-28T13:41:32Z

comments from Adrien 06/28/2023

pd - public_data

sk - starting_kit

~~allow the multiselect of pd and sk~~
red stars by pd and sk don't need to be there.
ref data always hidden.
everything shown for admin\organizers
(v1 bundles can upload 1 pd or sk)

New PR\Issue

competition level option to hide\show programs (scoring\ingestion)
competition level option to hide\show input_data
~~allow multiple public_data and starting_kits in yaml~~
(v2 bundles should handle multiple.)

Didayolo · 2023-07-18T15:28:07Z

Before the second PR, scoring program, ingestion program and input data should be unavailable by default (we do not want to force it to be public)
If there is no public data, starting kit, and everything else is not available, there should be a default sentence inside the table, like for the leaderboard (No files are available for download or something like this):

Didayolo · 2023-07-21T14:59:43Z

Hi @bbearce, I am testing this PR.

I can see the download buttons for starting kit and public data even if I am not logged in the platform nor registered for the competition.

As a reminder:

For non-approved participants: Not accessible

For approved participants: Showing objects made available by organizers

bbearce · 2023-07-24T22:48:07Z

Let me take a look.

bbearce · 2023-07-25T02:02:23Z

Ok here are the fixes:

Not logged in:
For non-approved participants: Not accessible:
For approved participants:
Showing objects made available by organizers. Organizers can unselect starting_kit and public_data and it won't be available:

Didayolo · 2023-07-25T09:03:58Z

@bbearce That is great! Thank you for the detailed screenshots. I'll review it as soon as possible.

Didayolo · 2023-07-25T09:09:45Z

EDIT: seems good after restarting the containers.

It is working fine. However, I see this in the logs, which seems to be related to the changes:

django.db.utils.ProgrammingError: column competitions_phase.public_data_id does not exist

Strangely, when I tried to run the migrations, no changes were detected.

More logs:

codabench-site_worker-1  | [2023-07-25 09:05:20,223: ERROR/ForkPoolWorker-3] Task competitions.tasks.submission_status_cleanup[3a1d70b5-8fb2-48b2-8bda-817340ebeb68] raised unexpected: ProgrammingError('column competitions_phase.public_data_id does not exist\nLINE 1: ...r_person", "competitions_phase"."leaderboard_id", "competiti...\n                                                             ^\n')
codabench-site_worker-1  | Traceback (most recent call last):
codabench-site_worker-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 84, in _execute
codabench-site_worker-1  |     return self.cursor.execute(sql, params)
codabench-site_worker-1  | psycopg2.errors.UndefinedColumn: column competitions_phase.public_data_id does not exist
codabench-site_worker-1  | LINE 1: ...r_person", "competitions_phase"."leaderboard_id", "competiti...

codabench-site_worker-1  | Traceback (most recent call last):
codabench-site_worker-1  |   File "/usr/local/lib/python3.8/site-packages/celery/app/trace.py", line 382, in trace_task
codabench-site_worker-1  |     R = retval = fun(*args, **kwargs)
codabench-site_worker-1  |   File "/usr/local/lib/python3.8/site-packages/celery/app/trace.py", line 641, in __protected_call__
codabench-site_worker-1  |     return self.run(*args, **kwargs)
codabench-site_worker-1  |   File "/app/src/apps/competitions/tasks.py", line 754, in submission_status_cleanup
codabench-site_worker-1  |     for sub in submissions:
codabench-site_worker-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/models/query.py", line 274, in __iter__
codabench-site_worker-1  |     self._fetch_all()
codabench-site_worker-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/models/query.py", line 1242, in _fetch_all
codabench-site_worker-1  |     self._result_cache = list(self._iterable_class(self))
codabench-site_worker-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/models/query.py", line 55, in __iter__
codabench-site_worker-1  |     results = compiler.execute_sql(chunked_fetch=self.chunked_fetch, chunk_size=self.chunk_size)
codabench-site_worker-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/models/sql/compiler.py", line 1142, in execute_sql
codabench-site_worker-1  |     cursor.execute(sql, params)
codabench-site_worker-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 67, in execute
codabench-site_worker-1  |     return self._execute_with_wrappers(sql, params, many=False, executor=self._execute)
codabench-site_worker-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 76, in _execute_with_wrappers
codabench-site_worker-1  |     return executor(sql, params, many, context)
codabench-site_worker-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 84, in _execute
codabench-site_worker-1  |     return self.cursor.execute(sql, params)
codabench-site_worker-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/utils.py", line 89, in __exit__
codabench-site_worker-1  |     raise dj_exc_value.with_traceback(traceback) from exc_value
codabench-site_worker-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 84, in _execute
codabench-site_worker-1  |     return self.cursor.execute(sql, params)
codabench-site_worker-1  | django.db.utils.ProgrammingError: column competitions_phase.public_data_id does not exist
codabench-site_worker-1  | LINE 1: ...r_person", "competitions_phase"."leaderboard_id", "competiti...

Didayolo · 2023-07-25T09:37:40Z

What is the YAML syntax for starting kit and public data? We need to update the documentation

Didayolo · 2023-07-25T09:41:02Z

All files are shown as available:

I'll merge anyway so we can start testing the feature on codabench-test, but this needs to be addressed.

Didayolo · 2023-07-25T09:45:14Z

I added the remaining TODOs in #764 ("second PR")

Didayolo · 2023-07-25T10:34:07Z

Solutions are available even if not logged in, and the table shows "No Files Available Yet"

bbearce · 2023-07-25T15:33:30Z

Bah! Ok. Working on the Solution and No Files Yet issue.

* do not show hidden column in leaderboard, unpacker v1 to handle hidden column * LEADERBOARD_V1 data updated with hidden attribute * filter: hidden condition removed * analytics download fixed * default profile avatar changed * Detailed results displayed for each task on leaderboard (#967) * Detailed results displayed for each task on leaderboard * more explanation added to detailed result fetching. url commented * detailed results removed from factsheets * Download buttons (#970) * download_buttons progress 06_03_2023 * List the Files on Files Tab * download buttons update * dataset download added to UI. * 06_24_2023 progress * unpackers, polishing and fixing test errors * last bit of test fixes. * flake issues * pytest errors * single select and final touches * flake and fixing tests * remove dev docker-compose file * hide all but public_startingkit data for no admin * Don't show non-registered\unlogged-in participants * Improve display --------- Co-authored-by: didayolo <adrien.pavao@gmail.com> --------- Co-authored-by: Ihsan Ullah <ihsan2131@gmail.com> Co-authored-by: Benjamin Bearce <bbearce@gmail.com>

ihsaan-ullah mentioned this pull request Jun 21, 2023

V1.5 compatibility - Unsupported features #723

Closed

7 tasks

bbearce added 7 commits June 25, 2023 19:23

download_buttons progress 06_03_2023

fa5215a

List the Files on Files Tab

c19d96d

download buttons update

50f2f68

dataset download added to UI.

e8bd080

06_24_2023 progress

777a862

unpackers, polishing and fixing test errors

1a21a3d

last bit of test fixes.

4a18694

bbearce force-pushed the download_buttons branch from 3e6e6e9 to 4a18694 Compare June 26, 2023 00:09

bbearce added 2 commits June 25, 2023 20:31

flake issues

ed6aa9a

pytest errors

d4f43ed

Didayolo added the In Progress label Jun 28, 2023

Didayolo mentioned this pull request Jun 28, 2023

Transparency of docker images and scoring programs #764

Closed

13 tasks

bbearce added 3 commits July 12, 2023 18:15

single select and final touches

e43c51c

flake and fixing tests

90ef0ca

remove dev docker-compose file

b929ea5

Didayolo removed the In Progress label Jul 18, 2023

hide all but public_startingkit data for no admin

983f420

Didayolo self-assigned this Jul 21, 2023

Don't show non-registered\unlogged-in participants

3c237b8

Improve display

0743a23

Didayolo merged commit 958071f into develop Jul 25, 2023

Didayolo deleted the download_buttons branch July 25, 2023 09:41

Didayolo mentioned this pull request Jul 25, 2023

Merge develop into master #1028

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Download buttons #970

Download buttons #970

Uh oh!

bbearce commented Jun 21, 2023 •

edited by Didayolo

Loading

Uh oh!

bbearce commented Jun 28, 2023 •

edited by Didayolo

Loading

Uh oh!

Didayolo commented Jul 18, 2023 •

edited

Loading

Uh oh!

Didayolo commented Jul 21, 2023

Uh oh!

bbearce commented Jul 24, 2023

Uh oh!

bbearce commented Jul 25, 2023 •

edited

Loading

Uh oh!

Didayolo commented Jul 25, 2023

Uh oh!

Didayolo commented Jul 25, 2023 •

edited

Loading

Uh oh!

Didayolo commented Jul 25, 2023

Uh oh!

Didayolo commented Jul 25, 2023

Uh oh!

Didayolo commented Jul 25, 2023

Uh oh!

Didayolo commented Jul 25, 2023

Uh oh!

bbearce commented Jul 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Download buttons #970

Download buttons #970

Uh oh!

Conversation

bbearce commented Jun 21, 2023 • edited by Didayolo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

@ mention of reviewers

A brief description of the purpose of the changes contained in this PR.

Issues this PR resolves

A checklist for hand testing

Make competition upload bundle

Make manual competition

Edit pre-existing competition

Double Check

Any relevant files for testing

Checklist

Uh oh!

bbearce commented Jun 28, 2023 • edited by Didayolo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

comments from Adrien 06/28/2023

pd - public_data

sk - starting_kit

New PR\Issue

Uh oh!

Didayolo commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Didayolo commented Jul 21, 2023

Uh oh!

bbearce commented Jul 24, 2023

Uh oh!

bbearce commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Didayolo commented Jul 25, 2023

Uh oh!

Didayolo commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Didayolo commented Jul 25, 2023

Uh oh!

Didayolo commented Jul 25, 2023

Uh oh!

Didayolo commented Jul 25, 2023

Uh oh!

Didayolo commented Jul 25, 2023

Uh oh!

bbearce commented Jul 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bbearce commented Jun 21, 2023 •

edited by Didayolo

Loading

bbearce commented Jun 28, 2023 •

edited by Didayolo

Loading

Didayolo commented Jul 18, 2023 •

edited

Loading

bbearce commented Jul 25, 2023 •

edited

Loading

Didayolo commented Jul 25, 2023 •

edited

Loading