Open
Conversation
…he index.js file, this also reflects in my test files
jalleng
reviewed
Feb 14, 2017
| const greet = require('./lib/greet.js'); | ||
|
|
||
| if(process.argv[2]) var name = process.argv[2]; | ||
| if(process.argv[2] === undefined) var name = 'Carne Asuhdude'; |
There was a problem hiding this comment.
There is nothing wrong with this. It works the way it is. However there is another way to do this variable assignment that is a fairly common practice. Look up 'ternary operator'. I'm not sure if you have used it before but it is quite useful. If you can't find what I am talking about and are still curious let me know and I will show you.
Author
There was a problem hiding this comment.
Yah ternary operators, we did that in 301! I'll take a stab at it, and come find you with any questions, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Woohoo!