-
Notifications
You must be signed in to change notification settings - Fork 16
Lab 01 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
npisciotti1
wants to merge
4
commits into
codefellows-javascript-401d13:master
Choose a base branch
from
npisciotti1:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lab 01 #5
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
01aec6b
created all necessary files
sneakyneeks2 2552cb2
created two tests for my greet.js module using assert in node.js
sneakyneeks2 8b7f44c
added the ability to pass a third argument in the command line into t…
sneakyneeks2 8cdebd9
cleaned up code, and hardcoded var name = 'Nikko' in greet-test.js
sneakyneeks2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| 'use strict'; | ||
|
|
||
| const greet = require('./lib/greet.js'); | ||
|
|
||
| if(process.argv[2]) var name = process.argv[2]; | ||
| if(process.argv[2] === undefined) var name = 'Carne Asuhdude'; | ||
|
|
||
| greet.greeting(name); | ||
| greet.goodbye(); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| 'use strict'; | ||
|
|
||
| module.exports = exports = {}; | ||
|
|
||
| exports.greeting = function(name) { | ||
| if(arguments.length === 0) throw new Error('No name name given, please input a name!'); | ||
| console.log(`Hello ${name}, pleasure to meet you`); | ||
| return `Hello ${name}, pleasure to meet you`; | ||
| }; | ||
|
|
||
| exports.goodbye = function() { | ||
| console.log('thanks for stopping by!'); | ||
| return 'thanks for stopping by!'; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| 'use strict'; | ||
|
|
||
| const greet = require('../lib/greet.js'); | ||
| const assert = require('assert'); | ||
|
|
||
| var name = 'Nikko'; | ||
|
|
||
| describe('Greet Module', function() { | ||
| describe('#greeting', function(){ | ||
| it(`function should return Hello ${name}, pleasure to meet you`, function(){ | ||
| var output = greet.greeting(name); | ||
| assert.ok(output === `Hello ${name}, pleasure to meet you`, 'Output does not match - fail'); | ||
| }); | ||
| }); | ||
| describe('#goodbye', function() { | ||
| it('function should log: thanks for stopping by!', function() { | ||
| var goodbye = greet.goodbye(); | ||
| assert.ok(goodbye === 'thanks for stopping by!', 'Output does not match - fail'); | ||
| }); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is nothing wrong with this. It works the way it is. However there is another way to do this variable assignment that is a fairly common practice. Look up 'ternary operator'. I'm not sure if you have used it before but it is quite useful. If you can't find what I am talking about and are still curious let me know and I will show you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yah ternary operators, we did that in 301! I'll take a stab at it, and come find you with any questions, thanks!