lang: [tr]&[uk] fix Invalid param in errorPasswordPwned#954
Merged
datamweb merged 2 commits intocodeigniter4:developfrom Nov 19, 2023
Merged
lang: [tr]&[uk] fix Invalid param in errorPasswordPwned#954datamweb merged 2 commits intocodeigniter4:developfrom
errorPasswordPwned#954datamweb merged 2 commits intocodeigniter4:developfrom
Conversation
Collaborator
Author
|
@paulbalandan If you can check this topic and add it to |
Member
|
I'm sorry I don't get what you mean. What do you want me to do? |
Collaborator
Author
|
This is the original text: 'errorPasswordPwned' => 'The password {0} has been exposed due to a data breach and has been seen {1, number} times in {2} of compromised passwords.',This text has been translated into another language, unfortunately number ({1, number}) have been translated in this field, which causes failure. 'errorPasswordPwned' => '{0} şifresi, bir veri ihlali nedeniyle açığa çıktı ve güvenliği ihlal edilmiş şifrelerin {2} tanesinde {1, sayı} kez görüldü.',In fact, we did not realize this during the merger. Now I want to see if you can check by Language Unit Test that strings like (({1, number})) should not be translated. |
kenjis
approved these changes
Nov 19, 2023
Member
|
Ok, I get it. I'll check what I can do. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ref: #953
Checklist: