chore: Add test for checking localization parameters are not translated#955
Merged
kenjis merged 1 commit intocodeigniter4:developfrom Dec 2, 2023
Merged
Conversation
677c8a8 to
1056c3a
Compare
datamweb
approved these changes
Nov 20, 2023
Collaborator
datamweb
left a comment
There was a problem hiding this comment.
This is what I wanted, it works fine on local.
There was 1 failure:
1) Tests\Language\UkrainianTranslationTest::testAllLocalizationParametersAreNotTranslated with data set "uk" ('uk')
Failed asserting that parameters of translation keys are not translated:
* Auth.errorPasswordLength => {0, number}
* Auth.errorPasswordPwned => {1, number}
* Auth.errorPasswordTooLongBytes => {param}
Failed asserting that an array is empty.
P:\MyGitHubWork\shield\tests\Language\AbstractTranslationTestCase.php:348@paulbalandan , thank you for doing it.
Member
Author
|
I just realized this may not work if a key has several parameters. I'll fix it tomorrow. |
1056c3a to
916f315
Compare
datamweb
approved these changes
Nov 21, 2023
Collaborator
datamweb
left a comment
There was a problem hiding this comment.
Excellent. Thank you.
18) Tests\Language\FarsiTranslationTest::testAllLocalizationParametersAreNotTranslated with data set "fa" ('fa')
Failed asserting that parameters of translation keys are not translated:
* Auth.throttled => {1}
* Auth.unknownAuthenticator => {1, number}, {2, number}, {3, number}
Failed asserting that an array is empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #954 (comment)
Checklist: