Skip to content

Fix: consistent heading structure across all admin screens #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rami-elementor merged 3 commits into from
Apr 25, 2026
Merged

Fix: consistent heading structure across all admin screens #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6019eab
Fix: consistent heading structure across all admin screens
rami-elementor Apr 18, 2026
f740927
Remove dead code - based on Copilot code review
rami-elementor Apr 18, 2026
a7c9658
Merge branch 'core-beta' into a11y-headings
rami-elementor Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/css/common/_upsell.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,21 +76,13 @@
p {
margin-block: 0;
margin-inline: 2em;
}

h1 + p {
font-size: 16px;
}

img {
inline-size: 82px;
}

h2 {
text-transform: uppercase;
font-size: 12px;
}

ul {
display: grid;
inline-size: 100%;
Expand Down
8 changes: 8 additions & 0 deletions src/css/edit.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,14 @@
}
}

.wrap > h2:first-of-type {
font-size: 1.5rem;
font-weight: 400;
line-height: 1.3;
padding: 0;
margin-block: 50px 1rem;
}

.snippet-name-wrapper {
display: flex;
gap: 0.5em;
Expand Down
23 changes: 5 additions & 18 deletions src/css/manage.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,25 +34,12 @@
margin-inline: 0;
}

.snippets-table-heading {
display: flex;
align-items: center;
margin-block: 50px 1.4rem;

h1 {
font-size: 1.6rem;
padding: 0;
}

.button-primary {
margin-inline-start: auto;
}
}

.wrap > h1:first-of-type {
font-size: 1.6rem;
.wrap > h2:first-of-type {
font-size: 1.5rem;
font-weight: 400;
line-height: 1.3;
padding: 0;
margin-block: 50px 1.4rem;
margin-block: 50px 1rem;

.subtitle {
vertical-align: middle;
Expand Down
8 changes: 8 additions & 0 deletions src/css/settings.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@

$sections: general, editor, debug, version-switch;

.wrap > h2:first-of-type {
font-size: 1.5rem;
font-weight: 400;
line-height: 1.3;
padding: 0;
margin-block: 50px 1rem;
}
Comment thread
rami-elementor marked this conversation as resolved.

p.submit {
display: flex;
justify-content: space-between;
Expand Down
18 changes: 5 additions & 13 deletions src/css/welcome.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@
$breakpoint: 1060px;

.code-snippets-welcome {
padding: 25px;

h2 {
font-size: 32px;
margin-block: 48px 32px;
font-size: 1.5rem;
font-weight: 500;
line-height: 1.3;
padding: 0;
margin-block: 50px 1rem;
}
}

Expand Down Expand Up @@ -176,15 +177,6 @@ $breakpoint: 1060px;
margin: 1em 0;
}

h5 {
font-size: 12px;
text-transform: uppercase;
margin: 0 0 16px;
display: flex;
gap: 5px;
align-items: center;
}

ul {
margin-block-start: 5px;
}
Expand Down
2 changes: 1 addition & 1 deletion src/js/components/ManageMenu/CommunityCloud/CommunityCloud.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const CommunityCloud = () => {

return (
<div className="wrap">
<h1>{__('Community Cloud', 'code-snippets')}</h1>
<h2>{__('Community Cloud', 'code-snippets')}</h2>

<nav
className="nav-tab-wrapper"
Expand Down
4 changes: 2 additions & 2 deletions src/js/components/ManageMenu/SnippetsTable/SnippetsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const PageHeading = () => {
{__('Create new snippet', 'code-snippets')}
</a>

<h1>
<h2>
{__('Manage Code Snippets', 'code-snippets')}

{searchQueryText || currentTag
Expand All @@ -86,7 +86,7 @@ const PageHeading = () => {
</Button>
</span>
: null}
</h1>
</h2>

<SafeModeNotice />
</>
Expand Down
2 changes: 1 addition & 1 deletion src/js/components/common/UpsellDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export const UpsellDialog: React.FC<UpsellDialogProps> = ({ isOpen, setIsOpen })
{__('Explore Code Snippets Pro', 'code-snippets')}
</a>
Comment thread
rami-elementor marked this conversation as resolved.

<h2>{__("Here's what else you get with Pro:", 'code-snippets')}</h2>
<p>{__("Here's what else you get with Pro:", 'code-snippets')}</p>
Comment thread
rami-elementor marked this conversation as resolved.
<ul>
<li>{__('Create, explain and verify snippets with AI', 'code-snippets')}</li>
<li>{__('Control when snippets run with Conditions', 'code-snippets')}</li>
Expand Down
6 changes: 3 additions & 3 deletions src/php/Admin/Menus/Settings_Menu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public function render() {

?>
<div class="code-snippets-settings wrap" data-active-tab="<?php echo esc_attr( $current_section ); ?>">
<h1>
<h2>
<?php
Comment thread
rami-elementor marked this conversation as resolved.
esc_html_e( 'Settings', 'code-snippets' );

Expand All @@ -219,7 +219,7 @@ public function render() {
}
}
?>
</h1>
</h2>

<?php settings_errors( OPTION_NAME ); ?>

Expand Down Expand Up @@ -275,7 +275,7 @@ protected function do_settings_tabs() {

if ( $section['title'] ) {
printf(
'<h2 id="%s-settings" class="settings-section-title">%s</h2>' . "\n",
'<h3 id="%s-settings" class="settings-section-title">%s</h3>' . "\n",
esc_attr( $section['id'] ),
esc_html( $section['title'] )
);
Expand Down
Loading