Fix: consistent heading structure across all admin screens#362
Merged
rami-elementor merged 3 commits intocore-betafrom Apr 25, 2026
Merged
Fix: consistent heading structure across all admin screens#362rami-elementor merged 3 commits intocore-betafrom
rami-elementor merged 3 commits intocore-betafrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes heading levels across several Code Snippets admin UIs (PHP-rendered Settings and multiple React screens) and adjusts the associated SCSS so page titles and section titles follow a consistent visual/semantic hierarchy.
Changes:
- Downgrade several screen “page title” headings from
h1→h2(and Settings section titles fromh2→h3). - Adjust/manage/edit/settings SCSS to style the new
h2page title pattern consistently. - Simplify the Upsell dialog markup by replacing a secondary heading with a paragraph and updating related styles.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/php/Admin/Menus/Settings_Menu.php | Adjusts Settings screen heading levels (h1→h2, section titles h2→h3). |
| src/js/components/common/UpsellDialog.tsx | Changes the “Pro benefits” label from a heading to a paragraph. |
| src/js/components/ManageMenu/SnippetsTable/SnippetsTable.tsx | Changes Manage screen page title heading from h1→h2. |
| src/js/components/ManageMenu/CommunityCloud/CommunityCloud.tsx | Changes Community Cloud screen heading from h1→h2. |
| src/js/components/EditMenu/SnippetForm/page/PageHeading.tsx | Changes Edit screen page title heading from h1→h2. |
| src/css/welcome.scss | Updates welcome screen heading styling and removes unused h5 styling. |
| src/css/settings.scss | Adds styling for .wrap > h2:first-of-type on Settings screens. |
| src/css/manage.scss | Updates Manage page heading selector to target h2 and removes old h1 styling. |
| src/css/edit.scss | Adds styling for .wrap > h2:first-of-type on Edit screens. |
| src/css/common/_upsell.scss | Aligns Upsell dialog styles with updated markup (removes h2 styling). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
<Toolbar>has a<h1>tag. The other<h1>tags should be downgraded, and the sizes should be consistent across all the admin screens.