Skip to content

Fix: consistent heading structure across all admin screens#365

Merged
rami-elementor merged 5 commits intocore-betafrom
import-screen
May 1, 2026
Merged

Fix: consistent heading structure across all admin screens#365
rami-elementor merged 5 commits intocore-betafrom
import-screen

Conversation

@rami-elementor
Copy link
Copy Markdown
Contributor

@rami-elementor rami-elementor commented Apr 23, 2026

More updated after #362 :

  • enforce consistent heading structure across all admin screens
  • add top toolbar to the import screen
  • remove many unnecessary wrapping <div> elements
  • remove duplicate .wrap classes
  • move .wrap classes to upper <div>

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the shared top toolbar to the Import screen and adjusts the Import/Migrate UI structure/styles to fit the updated page layout and heading hierarchy.

Changes:

  • Render the shared Toolbar on the Import screen and adjust the Import page heading/layout containers.
  • Normalize heading levels across Import/Migrate cards and tweak related SCSS (including max-width handling).
  • Extend toolbar nav-link metadata (pageSlug/subpage) to improve active-link detection.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/js/components/ImportMenu/UploadForm/UploadForm.tsx Removes nested .wrap/container wrappers so Upload step fits within the Import page layout.
src/js/components/ImportMenu/UploadForm/SelectSnippets/SelectSnippets.tsx Adjusts the “Available snippets” heading level in the selection step.
src/js/components/ImportMenu/UploadForm/SelectSnippets/ImportResultDisplay.tsx Updates result icon accessibility and adjusts result heading level.
src/js/components/ImportMenu/UploadForm/SelectFiles/SelectFiles.tsx Shifts card heading level to match the new Import page hierarchy.
src/js/components/ImportMenu/UploadForm/SelectFiles/SelectedFilesList.tsx Shifts selected-files heading level to match the new Import page hierarchy.
src/js/components/ImportMenu/UploadForm/SelectFiles/DuplicateActionSelector.tsx Shifts duplicate-action card heading level to match the new Import page hierarchy.
src/js/components/ImportMenu/MigrateForm/SimpleSnippetTable.tsx Shifts migrate table card heading level to align with updated hierarchy.
src/js/components/ImportMenu/MigrateForm/MigrateForm.tsx Removes extra container wrapper and adjusts status/no-results headings.
src/js/components/ImportMenu/MigrateForm/ImportOptions.tsx Shifts “Import options” heading level for hierarchy consistency.
src/js/components/ImportMenu/MigrateForm/ImporterSelector.tsx Shifts “Select plugin” heading level for hierarchy consistency.
src/js/components/ImportMenu/ImportMenu.tsx Adds Toolbar and updates Import page title/structure.
src/js/components/EditMenu/SnippetForm/SnippetForm.tsx Removes .wrap wrapper around the edit form content.
src/js/components/common/Toolbar.tsx Adds pageSlug/subpage metadata and refactors active-link detection.
src/css/import/_upload.scss Updates selectors to match revised heading levels and removes width container styling.
src/css/import/_page.scss Updates Import page header and section sizing/layout rules.
src/css/import/_migrate.scss Updates selectors to match revised heading levels and removes width container styling.
src/css/import/_card.scss Ensures card sizing includes borders via box-sizing: border-box.
src/css/import.scss Imports toolbar styles into the import stylesheet bundle.

Comment thread src/js/components/EditMenu/SnippetForm/SnippetForm.tsx
Comment thread src/js/components/ImportMenu/MigrateForm/MigrateForm.tsx
Comment thread src/js/components/common/Toolbar.tsx
Base automatically changed from a11y-headings to core-beta April 25, 2026 16:17
@rami-elementor rami-elementor marked this pull request as ready for review April 25, 2026 18:51
@rami-elementor rami-elementor changed the title Fix: add top toolbar to the import screen Fix: consistent heading structure across all admin screens Apr 25, 2026
@rami-elementor rami-elementor requested a review from a team April 29, 2026 11:56
@rami-elementor rami-elementor merged commit 633ea47 into core-beta May 1, 2026
8 checks passed
@rami-elementor rami-elementor deleted the import-screen branch May 1, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants