fix: scrubber beacon label immediate updates#570
Merged
Conversation
Collaborator
✅ Heimdall Review Status
✅
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
✅
1/1
|
Denominator calculation
|
hcopp
commented
Mar 31, 2026
| const y = useDerivedValue( | ||
| () => (unwrapAnimatedValue(isIdle) ? idleAnimatedY.value : targetY.value), | ||
| [isIdle, idleAnimatedY, targetY], | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
This ensures we are always up to date vs potentially 1 frame behind.
hcopp
commented
Mar 31, 2026
| idleAnimatedY.value = buildTransition(current.y, updateTransition); | ||
| } else { | ||
| animatedY.value = buildTransition(current.y, updateTransition); | ||
| idleAnimatedY.value = current.y; |
Contributor
Author
There was a problem hiding this comment.
Similar logic as before but simpler.
Contributor
8 tasks
cb-ekuersch
pushed a commit
that referenced
this pull request
Apr 2, 2026
* fix: scrubber beacon label immediate updates * Bump version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR fixes a potential single frame delay in scrubber beacon labels. This caused the label to sometimes be at the previous y value location for 1 frame too long and thus would glitch as the user started scrubbing.
Root cause (required for bugfixes)
This happened because useAnimatedReaction, wouldn't always immediately update as scrubbing occurred, resulting in a single frame where the labels were off vertically.
Switching to using useAnimatedReaction for the animations only (as we do elsewhere) and relying on useDerivedValue to set the y position of labels when scrubbing solves this.
UI changes
Not sure if the gif showcases this but it is visible in predictions for college basketball tournament. Much easier to tell from a human eye.
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false