Merged
Conversation
Collaborator
✅ Heimdall Review Status
✅
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
✅
2/1
|
Denominator calculation
|
adrienzheng-cb
approved these changes
Apr 1, 2026
maximo-macchi-cb
approved these changes
Apr 1, 2026
Contributor
cb-ekuersch
pushed a commit
that referenced
this pull request
Apr 2, 2026
* fix: mobile scrubber initial load glitch * Bump version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR improves the mobile scrubber initial render. This is already solved on web by not rendering when value isn't set (see DefaultScrubberBeacon and ScrubberBeaconLabelGroup).
Note this is separate from #570 which occurred each time the user started scrubbing.
Root cause (required for bugfixes)
For initial load, scrubber beacon and label were rendering at a y value of 0. This has been fixed by defaulting to null and for scrubber beacon rendering in the correct spot to start and for the label not rendering until we know the location.
Most of the time this isn't a problem since we have an initial animation, however removing this and having a large screen (such as multiple charts) can cause this to happen where the value isn't calculated until 1 frame later.
The last issue one could see here is that the labels spawn in their initial location and then animate but this would be an extra step where we have to render them visually but with 0 opacity. I believe this current solution suffices and that teams will be adopting animations over time as we continue to iterate on customization.
UI changes
ScrubberBefore.mov
ScrubberAfter.mov
Testing
How has it been tested?
Testing instructions
Edit
Scrubber.stories.tsxon mobile to addanimate={false}to both ofPercentageBeaconLabelscharts.Then go to 'Scrubber' > 'Percentage Beacon Labels' (example 8 of 16) and compare master to this branch (keeping the
animate={false}change).Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false