FEC-294: update NPM package publishing setup#3198
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: dd8116a The changes in this PR will be included in the next version bump. This PR includes changesets to release 101 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jaikumar-tj
added
the
fe-chapter-rotation
jaikumar-tj
commented
Nov 21, 2025
Comment on lines
-73
to
-77
| - name: Checking bundle size of visual testing app | ||
| run: yarn bundlesize | ||
| # env: | ||
| # NOTE: it seems that currently bundlesize server is having problems | ||
| # resulting in status code 500. Because of that, the bundlesize script |
Contributor
Author
There was a problem hiding this comment.
The issue is that iltorb@2.4.5 (a dependency of brotli-size@0.1.0, which is used by bundlesize) doesn't support Node.js 24 because it uses deprecated V8 APIs.
I'm trying to find a alternate solution to resolve this
Contributor
Author
There was a problem hiding this comment.
Unfortunately this new github action also seems to use same iltorb. will keep digging
Contributor
Author
There was a problem hiding this comment.
bundlewatch package works with node 24 and it expects a token if we want it to update the status of PR. Let me know if you think we can go with bundlewatch or not. Currently it generates same output as the previous bundlesize package.
https://bundlewatch.io/guide/using-bundlewatch
Contributor
There was a problem hiding this comment.
Yes. I think we can swap.
Contributor
|
I need to update all 42 packages on NPM manually. This can't be real :D |
ragafus
approved these changes
Nov 21, 2025
tdeekens
approved these changes
Nov 21, 2025
Comment on lines
-73
to
-77
| - name: Checking bundle size of visual testing app | ||
| run: yarn bundlesize | ||
| # env: | ||
| # NOTE: it seems that currently bundlesize server is having problems | ||
| # resulting in status code 500. Because of that, the bundlesize script |
Contributor
There was a problem hiding this comment.
Yes. I think we can swap.
Contributor
|
Is the ui-kit also using Vercel deploys commercetools/merchant-center-application-kit#3881? 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After bumping npmrc version, the
bundlesizewas causing an issue since it is not compatible with latest node (refer below comment). I replaced it withbundlewatch.