CRAFT-2033: updates to release and preview release workflows for trusted publishing#3219
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
[preview_deployment] |
|
@tylermorrisford, thank you for taking this on 🙌🏻 TL;DR - The work to switch to the trusted publishing has already been completed here A catch was, the move to trusted publishing only allows for one workflow to be configured. The PR description here might help. So we need to reconfigure the uikit to have a single workflow point of entry that then is directed (switched) to different publishing scenarios. I need to see how uikit is set up, but i can def help you work thru this. |
|
within uikit we will use very much like appkit it will look a lot more scaled back and contain a ref to 2 jobs: The appkit workflows have comments that aid in explaining which each one does |
ByronDWall
left a comment
There was a problem hiding this comment.
I see where you're going here, and this will probably work, but I think it makes sense to follow the same patterns we have in app kit for the sake of consistency and maintainability
| @@ -0,0 +1,40 @@ | |||
| name: Preview Release (Caller) | |||
There was a problem hiding this comment.
This should be handled in the revamped release.yaml which will call the appropriate release workflow based on the github event that triggered it
| permissions: | ||
| id-token: write | ||
| contents: read | ||
| workflow_call: |
There was a problem hiding this comment.
This file should be renamed to publish-release, and updated to match the pattern in app-kit.
The new release.yml should then choose whether to run publish-release or preview-release-on-comment, like in app-kit
| @@ -1,19 +1,28 @@ | |||
| name: Preview Release on Comment | |||
There was a problem hiding this comment.
We should name the file `preview-release-on-comment, and update the file to match the same patterns as in app-kit
| run: | | ||
| if [[ ! "$BRANCH_NAME" =~ ^preview/[a-zA-Z0-9_-]+$ ]]; then | ||
| echo "Ignoring PR because of the branch name. Exiting workflow." | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
We aren't limiting preview releases to only branch names that are prefixed with preview/. We want any PR to have the ability to be preview released with the proper comment
|
[preview_deployment] |
valoriecarli
left a comment
There was a problem hiding this comment.
thanks for taking this one on and for being patient as i worked through some of the differences b/w the appkit & uikit setups.
im sure you can see that the [preview_deployment] will fail as its not running the updated rule.
we can easily throw the updated rule in a pr and merge it to test it here, or just merge this and then test it. nothing will blow up too much.
@valoriecarli Thank you for all the help! Let's merge this and then test on one of the open PRs? |
Summary
publishing's single-workflow requirement
Test plan