Skip to content

CRAFT-2033: updates to release and preview release workflows for trusted publishing#3219

Merged
tylermorrisford merged 6 commits into
mainfrom
CRAFT-2033
Feb 17, 2026
Merged

CRAFT-2033: updates to release and preview release workflows for trusted publishing#3219
tylermorrisford merged 6 commits into
mainfrom
CRAFT-2033

Conversation

@tylermorrisford
Copy link
Copy Markdown
Contributor

@tylermorrisford tylermorrisford commented Feb 13, 2026

Summary

  • Restructure release workflows to use a single entry point (release.yml) that dispatches to reusable workflows, matching the appkit pattern and adhering to npm trusted
    publishing's single-workflow requirement
  • release.yml handles both push (to main) and issue_comment triggers, routing to publish-release.yml or preview-release-on-comment.yml
  • Preview releases are no longer restricted to preview/* branches — any PR can be preview-released with a [preview_deployment] comment
  • Removed --provenance flags to align with appkit

Test plan

  • Push to main triggers release.yml → publish-release.yml
  • Commenting [preview_deployment] on any PR triggers release.yml → preview-release-on-comment.yml
  • Preview tag is derived from the branch name with non-alphanumeric characters replaced by -
  • PR comment with workflow result is posted on success and failure
  • id-token: write permission is set on both jobs for npm trusted publishing

@tylermorrisford tylermorrisford self-assigned this Feb 13, 2026
@tylermorrisford tylermorrisford requested a review from a team as a code owner February 13, 2026 15:02
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 13, 2026

⚠️ No Changeset found

Latest commit: 760fb61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ui-kit Ready Ready Preview, Comment Feb 13, 2026 5:46pm

Request Review

@valoriecarli
Copy link
Copy Markdown
Contributor

[preview_deployment]

@valoriecarli
Copy link
Copy Markdown
Contributor

valoriecarli commented Feb 13, 2026

@tylermorrisford, thank you for taking this on 🙌🏻
The ticket for this might have been misleading, as there was history leading up to the appkit changes, so it was all lumped into that ticket for tracing purposes.

TL;DR - The work to switch to the trusted publishing has already been completed here

A catch was, the move to trusted publishing only allows for one workflow to be configured. The PR description here might help.

So we need to reconfigure the uikit to have a single workflow point of entry that then is directed (switched) to different publishing scenarios.

I need to see how uikit is set up, but i can def help you work thru this.
With that being said, maybe part of this is still needed. ill look into it more after this meeting.

@valoriecarli
Copy link
Copy Markdown
Contributor

valoriecarli commented Feb 13, 2026

within uikit we will use release.yml as the point of entry. its mostly moving parts around.

very much like appkit it will look a lot more scaled back and contain a ref to 2 jobs:
1 will point to publish-release.yml
       --note that this is the one that also contains the canary release
1 will point to publish-preview

The appkit workflows have comments that aid in explaining which each one does

Copy link
Copy Markdown
Contributor

@ByronDWall ByronDWall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see where you're going here, and this will probably work, but I think it makes sense to follow the same patterns we have in app kit for the sake of consistency and maintainability

@@ -0,0 +1,40 @@
name: Preview Release (Caller)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be handled in the revamped release.yaml which will call the appropriate release workflow based on the github event that triggered it

Comment thread .github/workflows/release.yml Outdated
permissions:
id-token: write
contents: read
workflow_call:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be renamed to publish-release, and updated to match the pattern in app-kit.

The new release.yml should then choose whether to run publish-release or preview-release-on-comment, like in app-kit

@@ -1,19 +1,28 @@
name: Preview Release on Comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should name the file `preview-release-on-comment, and update the file to match the same patterns as in app-kit

Comment on lines +26 to +30
run: |
if [[ ! "$BRANCH_NAME" =~ ^preview/[a-zA-Z0-9_-]+$ ]]; then
echo "Ignoring PR because of the branch name. Exiting workflow."
exit 1
fi
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't limiting preview releases to only branch names that are prefixed with preview/. We want any PR to have the ability to be preview released with the proper comment

@tylermorrisford
Copy link
Copy Markdown
Contributor Author

[preview_deployment]

Copy link
Copy Markdown
Contributor

@valoriecarli valoriecarli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking this one on and for being patient as i worked through some of the differences b/w the appkit & uikit setups.

im sure you can see that the [preview_deployment] will fail as its not running the updated rule.

we can easily throw the updated rule in a pr and merge it to test it here, or just merge this and then test it. nothing will blow up too much.

@tylermorrisford
Copy link
Copy Markdown
Contributor Author

thanks for taking this one on and for being patient as i worked through some of the differences b/w the appkit & uikit setups.

im sure you can see that the [preview_deployment] will fail as its not running the updated rule.

we can easily throw the updated rule in a pr and merge it to test it here, or just merge this and then test it. nothing will blow up too much.

@valoriecarli Thank you for all the help! Let's merge this and then test on one of the open PRs?

@tylermorrisford tylermorrisford merged commit efdd04e into main Feb 17, 2026
9 checks passed
@tylermorrisford tylermorrisford deleted the CRAFT-2033 branch February 17, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants