Skip to content

PSCE-256 - Add create-cd GitHub Action#68

Merged
jpower432 merged 6 commits intocomplytime:mainfrom
jpower432:PSCE-256-P2
Oct 26, 2023
Merged

PSCE-256 - Add create-cd GitHub Action#68
jpower432 merged 6 commits intocomplytime:mainfrom
jpower432:PSCE-256-P2

Conversation

@jpower432
Copy link
Copy Markdown
Member

@jpower432 jpower432 commented Oct 24, 2023

Description

Follow on PR to #67

This the action.yml, documentation, and bash entrypoint script.
Updates the Dockerfile to combine RUN directives to reduce image layers.

TODO: Add an issue to address duplicate of logic in bash and in README.md files.

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • Integration testing

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Copy link
Copy Markdown
Contributor

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired code review on October 26

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432 jpower432 merged commit 8cae7bc into complytime:main Oct 26, 2023
@jpower432 jpower432 deleted the PSCE-256-P2 branch March 26, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants