Unbinding window events when cancelling hide #38
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the window events can be bound multiple times in some cases. If the hide is cancelled,
then show is called again (ie: mouseover/out fun times) the winEvents simply get bound again,
causing the previous handler to be forever bound (since unbind only gets the last one in the stack
apparently, probably needs to be addressed in component/events somehow)
This could probably be addressed more completely by using mouseenter/leave instead of mouseover/out,
but that is not addressed in this commit.