improve binding of 'scroll' and 'resize' handlers #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I don’t really have a clear mind right now to really see through all that logic. So if you feel this is correct, go for it. |
Member
Author
|
Thanks for reviewing it. I am OK with letting it simmer for a bit. |
Member
|
This is a much better fix than my own, so I'd much rather see this merged. This should close #38 once it is merged. |
pirxpilot
added a commit
that referenced
this pull request
Apr 8, 2014
improve binding of 'scroll' and 'resize' handlers
Member
Author
|
thanks - released in 1.0.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure that 'scroll' and 'resize' handlers are in all cases bound at most once, and that they are always unbound when Tip is removed
fixes #38
fixes #25