fix: commerceconnector title prop#26
Merged
dannytlake merged 1 commit intocomposable-com:mainfrom Feb 13, 2024
Merged
Conversation
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 41555e2 |
|
@maria0r is attempting to deploy a commit to the Composable Development Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Fixed misalignment with the commerce connector component. The base definition was expecting
sectionTitle, buttitlewas being provided.titleis in line with other component type definitions, so I've updated the commerce connector to have atitle.Also cleaned up the static home page data, which was providing a
titlein the commerce connector component. It wasn't previous displaying due to this bug, and now that the bug is fixed, it's not necessary as a header and subheader are being provided for the featured product collection through abannerTextOnly. I also removed thectaMinWidthandctaMaxWidthbecause there was no CTA provided for this component, making them unnecessary.