Skip to content

fix: commerceconnector title prop #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dannytlake merged 1 commit into from
Feb 13, 2024
Merged

fix: commerceconnector title prop #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions composable-ui/src/components/cms/commerce-connector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { ProductCard } from '@composable/ui'
import { useRouter } from 'next/router'

export interface GenericConnectorProps {
sectionTitle?: string
title?: string
ctaLabel?: string
ctaHref?: string
ctaHeight?: string
Expand All @@ -30,7 +30,7 @@ export interface PriceProps {

export const CommerceConnector = (props: GenericConnectorProps) => {
const {
sectionTitle,
title,
ctaLabel,
ctaHref,
products,
Expand All @@ -48,8 +48,8 @@ export const CommerceConnector = (props: GenericConnectorProps) => {
<Flex
gap={{ base: '0.5rem', md: '0.625rem' }}
mb={{
base: sectionTitle && ctaHref ? '8' : undefined,
md: sectionTitle && ctaHref ? '12' : undefined,
base: title && ctaHref ? '8' : undefined,
md: title && ctaHref ? '12' : undefined,
}}
justifyContent={'space-between'}
>
Expand All @@ -58,7 +58,7 @@ export const CommerceConnector = (props: GenericConnectorProps) => {
textStyle={{ base: 'Body-L', md: 'Body-XL' }}
color={'primary'}
>
{sectionTitle}
{title}
</Text>
{ctaLabel && ctaHref && (
<Button onClick={() => router.push(ctaHref)}>{ctaLabel}</Button>
Expand Down
5 changes: 1 addition & 4 deletions packages/cms-generic/src/data/pages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,6 @@
"containerMarginBottom": "5",
"containerMarginTop": "5",
"containerSize": "full",
"ctaMaxWidth": "362px",
"ctaMinWidth": "290px",
"id": "44968ea0-70f9-494f-b88c-d7ffe4804597",
"products": [
{
Expand Down Expand Up @@ -269,8 +267,7 @@
},
"slug": "casual-short-sleeve-dress-in-bone"
}
],
"title": "Women collections"
]
},
{
"__typename": "BannerTextOnly",
Expand Down