Skip to content

Try OSX#13

Merged
fcollonval merged 4 commits into
conda-forge:mainfrom
jschueller:osx
Nov 21, 2023
Merged

Try OSX#13
fcollonval merged 4 commits into
conda-forge:mainfrom
jschueller:osx

Conversation

@jschueller
Copy link
Copy Markdown
Contributor

@conda-forge-admin please rerender

@conda-forge-webservices
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jschueller jschueller marked this pull request as draft November 5, 2023 10:30
conda-forge-webservices[bot] and others added 2 commits November 5, 2023 11:37
@jschueller jschueller force-pushed the osx branch 4 times, most recently from d195f1b to 1532ec5 Compare November 5, 2023 12:26
@jschueller jschueller marked this pull request as ready for review November 6, 2023 18:06
@jschueller
Copy link
Copy Markdown
Contributor Author

This is ready @fcollonval @markaren

Copy link
Copy Markdown
Contributor

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use this package since a long time. So I let @markaren have a look.

@jschueller if you don't hear from us in a couple of weeks. Don't hesitate to ping me. I'll gladly add you as maintainer.

Comment thread recipe/0001-Fix-pythonfmu-export-module-on-OSX.patch Outdated
@jschueller
Copy link
Copy Markdown
Contributor Author

@markaren @fcollonval I guess this should be merged too now the upstream patch has been accepted

Copy link
Copy Markdown
Contributor

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jschueller

@fcollonval fcollonval merged commit d42e798 into conda-forge:main Nov 21, 2023
@fcollonval fcollonval mentioned this pull request Nov 21, 2023
@jschueller jschueller deleted the osx branch November 21, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants