Skip to content

CI: test against Go 1.15#171

Merged
estesp merged 1 commit into
containerd:masterfrom
thaJeztah:bump_go_1.14
Aug 24, 2020
Merged

CI: test against Go 1.15#171
estesp merged 1 commit into
containerd:masterfrom
thaJeztah:bump_go_1.14

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

No description provided.

@thaJeztah thaJeztah marked this pull request as ready for review July 3, 2020 11:00
@thaJeztah thaJeztah changed the title [draft] CI: test against Go 1.14 CI: test against Go 1.14 Jul 3, 2020
@thaJeztah thaJeztah closed this Jul 3, 2020
@thaJeztah thaJeztah reopened this Jul 3, 2020
@estesp
Copy link
Copy Markdown
Member

estesp commented Jul 7, 2020

Just FYI, we also just merged #173 which solves the EINTR issue w/Go 1.14.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member Author

Just FYI, we also just merged #173 which solves the EINTR issue w/Go 1.14.

Ah, nice

Should we make that function conditional (so for Go > 1.15 just use ioutil.WriteFile ?)

@estesp
Copy link
Copy Markdown
Member

estesp commented Aug 17, 2020

should this be updated to 1.14.7 if we are still considering this?

@thaJeztah
Copy link
Copy Markdown
Member Author

Perhaps best to skip 1.14 and go directly to 1.15; let me update

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah changed the title CI: test against Go 1.14 CI: test against Go 1.15 Aug 17, 2020
@thaJeztah
Copy link
Copy Markdown
Member Author

Updated to Go 1.15

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 0b889c0 into containerd:master Aug 24, 2020
@thaJeztah thaJeztah deleted the bump_go_1.14 branch August 24, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants