Retry file writes on EINTR errors#173
Merged
Merged
Conversation
adunham-stripe
force-pushed
the
adunham/writefile-eintr
branch
2 times, most recently
from
f2c27b8 to
8e734c8
Compare
Go 1.14 introduces asynchronous preemption, which results in
applications that invoke slow syscalls (e.g. writing to a cgroup file)
getting EINTR errors. The Go runtime will fix this in version 1.15
onwards:
golang/go#38033
But this fix won't be backported:
golang/go#39026 (comment)
As such, introduce a 'writeFile' helper function that retries when the
error is an EINTR error.
Signed-off-by: Andrew Dunham <adunham@stripe.com>
adunham-stripe
force-pushed
the
adunham/writefile-eintr
branch
from
8e734c8 to
44e3a02
Compare
AkihiroSuda
approved these changes
Jul 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.14 introduces asynchronous preemption, which results in
applications that invoke slow syscalls (e.g. writing to a cgroup file)
getting EINTR errors. The Go runtime will fix this in version 1.15
onwards:
golang/go#38033
But this fix won't be backported:
golang/go#39026 (comment)
As such, introduce a 'writeFile' helper function that retries when the
error is an EINTR error.
This is also the approach taken in
runc: opencontainers/runc#2258Signed-off-by: Andrew Dunham adunham@stripe.com