Skip to content

Conversation

@unkaktus
Copy link
Contributor

@unkaktus unkaktus commented Mar 4, 2018

No description provided.

@@ -0,0 +1,28 @@
// +build openbsd
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this identical to stat_linux.go ? could we use the same file with build tags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow, nice catch!
stat_linux.go has to be renamed though. what name should it have?

@unkaktus unkaktus force-pushed the fs-openbsd branch 2 times, most recently from 6c334a7 to bdffa55 Compare October 12, 2018 21:28
@unkaktus
Copy link
Contributor Author

hey there again!
I made corresponding changes and squashed all the things :)

@unkaktus unkaktus mentioned this pull request Oct 12, 2018
9 tasks
@unkaktus
Copy link
Contributor Author

unkaktus commented Nov 5, 2018

@dnephin ping :)

@unkaktus unkaktus force-pushed the fs-openbsd branch 3 times, most recently from 5b6b2a7 to 58f8276 Compare November 5, 2018 19:16
@unkaktus
Copy link
Contributor Author

unkaktus commented Nov 5, 2018

I have no idea why CI failed here in one case.

Signed-off-by: Ivan Markin <sw@nogoegst.net>
@unkaktus
Copy link
Contributor Author

unkaktus commented Jan 23, 2019

It seems it was a purely CI issue last time.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 26c1120 into containerd:master Jan 7, 2020
thaJeztah added a commit to thaJeztah/buildkit that referenced this pull request Jan 13, 2020
…ce1fc84c4c4

full diff: containerd/continuity@75bee3e...26c1120

- containerd/continuity#109 Add OpenBSD support for fs subpackage
- containerd/continuity#144 Support Go Modules
- containerd/continuity#147 xattr lost when copying directory
- containerd/continuity#148 fs: don't convert syscall.Timespec to unix.Timespec directly (doesn't work with gccgo)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/buildkit that referenced this pull request Jan 13, 2020
…ce1fc84c4c4

full diff: containerd/continuity@75bee3e...26c1120

- containerd/continuity#109 Add OpenBSD support for fs subpackage
- containerd/continuity#144 Support Go Modules
- containerd/continuity#147 xattr lost when copying directory
- containerd/continuity#148 fs: don't convert syscall.Timespec to unix.Timespec directly (doesn't work with gccgo)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/docker that referenced this pull request Jan 13, 2020
…ce1fc84c4c4

full diff: containerd/continuity@f2a389a...26c1120

- containerd/continuity#109 Add OpenBSD support for fs subpackage
- containerd/continuity#141 Add src string to copyDirectory error message
- containerd/continuity#143 fstest: have CreateSocket actually create a socket
- containerd/continuity#144 Support Go Modules
- containerd/continuity#147 xattr lost when copying directory
- containerd/continuity#148 fs: don't convert syscall.Timespec to unix.Timespec directly (doesn't work with gccgo)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Jan 13, 2020
…ce1fc84c4c4

full diff: containerd/continuity@f2a389a...26c1120

- containerd/continuity#109 Add OpenBSD support for fs subpackage
- containerd/continuity#141 Add src string to copyDirectory error message
- containerd/continuity#143 fstest: have CreateSocket actually create a socket
- containerd/continuity#144 Support Go Modules
- containerd/continuity#147 xattr lost when copying directory
- containerd/continuity#148 fs: don't convert syscall.Timespec to unix.Timespec directly (doesn't work with gccgo)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: 67a0695e8b355c7a1c3382b7165f97a2bafc5f9b
Component: engine
thaJeztah added a commit to thaJeztah/buildkit that referenced this pull request Jan 16, 2020
…ce1fc84c4c4

full diff: containerd/continuity@75bee3e...26c1120

- containerd/continuity#109 Add OpenBSD support for fs subpackage
- containerd/continuity#144 Support Go Modules
- containerd/continuity#147 xattr lost when copying directory
- containerd/continuity#148 fs: don't convert syscall.Timespec to unix.Timespec directly (doesn't work with gccgo)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit e0ac634)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/cli that referenced this pull request Feb 12, 2020
…ce1fc84c4c4

full diff: containerd/continuity@f2a389a...26c1120

full diff: containerd/continuity@f2a389a...26c1120

- containerd/continuity#109 Add OpenBSD support for fs subpackage
- containerd/continuity#141 Add src string to copyDirectory error message
- containerd/continuity#143 fstest: have CreateSocket actually create a socket
- containerd/continuity#144 Support Go Modules
- containerd/continuity#147 xattr lost when copying directory
- containerd/continuity#148 fs: don't convert syscall.Timespec to unix.Timespec directly (doesn't work with gccgo)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/cli that referenced this pull request Feb 12, 2020
…ce1fc84c4c4

full diff: containerd/continuity@f2a389a...26c1120

full diff: containerd/continuity@f2a389a...26c1120

- containerd/continuity#109 Add OpenBSD support for fs subpackage
- containerd/continuity#141 Add src string to copyDirectory error message
- containerd/continuity#143 fstest: have CreateSocket actually create a socket
- containerd/continuity#144 Support Go Modules
- containerd/continuity#147 xattr lost when copying directory
- containerd/continuity#148 fs: don't convert syscall.Timespec to unix.Timespec directly (doesn't work with gccgo)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Feb 13, 2020
…ce1fc84c4c4

full diff: containerd/continuity@f2a389a...26c1120

full diff: containerd/continuity@f2a389a...26c1120

- containerd/continuity#109 Add OpenBSD support for fs subpackage
- containerd/continuity#141 Add src string to copyDirectory error message
- containerd/continuity#143 fstest: have CreateSocket actually create a socket
- containerd/continuity#144 Support Go Modules
- containerd/continuity#147 xattr lost when copying directory
- containerd/continuity#148 fs: don't convert syscall.Timespec to unix.Timespec directly (doesn't work with gccgo)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: 507e6b61cf82059ce412ccdb531b0e9402d2d2a8
Component: cli
eiffel-fl pushed a commit to eiffel-fl/cli that referenced this pull request Jul 28, 2020
…ce1fc84c4c4

full diff: containerd/continuity@f2a389a...26c1120

full diff: containerd/continuity@f2a389a...26c1120

- containerd/continuity#109 Add OpenBSD support for fs subpackage
- containerd/continuity#141 Add src string to copyDirectory error message
- containerd/continuity#143 fstest: have CreateSocket actually create a socket
- containerd/continuity#144 Support Go Modules
- containerd/continuity#147 xattr lost when copying directory
- containerd/continuity#148 fs: don't convert syscall.Timespec to unix.Timespec directly (doesn't work with gccgo)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants